Differential D5737

web_scenario: Silence type warnings when using requests-mock
ClosedPublic
Actions

Authored by vlorentz on May 11 2021, 12:19 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDICPdb1be8b000ad: web_scenario: Silence type warnings when using requests-mock

Summary

requests-mock 1.9.0 added stub files; but they are incomplete so it raises
typing error when running mypy on code using advanced features.

Diff Detail

Repository

rDICP Icinga plugins

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21468
Build 33351: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 33350: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 11 2021, 12:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 11 2021, 12:19 PM

Build is green

Patch application report for D5737 (id=20494)

Rebasing onto 8878925a6c...

Current branch diff-target is up to date.

Changes applied before test

commit db1be8b000ad19c847f0df66055bb9859ff7aa44
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 11 12:19:13 2021 +0200

    web_scenario: Silence type warnings when using requests-mock
    
    requests-mock 1.9.0 added stub files; but they are incomplete so it raises
    typing error when running mypy on code using advanced features.

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/33/ for more details.

Harbormaster completed remote builds in B21468: Diff 20494.May 11 2021, 12:20 PM

vlorentz requested review of this revision.May 11 2021, 12:20 PM

anlambert accepted this revision.May 11 2021, 12:25 PM

This revision is now accepted and ready to land.May 11 2021, 12:25 PM

Closed by commit rDICPdb1be8b000ad: web_scenario: Silence type warnings when using requests-mock (authored by vlorentz). · Explain WhyMay 11 2021, 12:25 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDICPdb1be8b000ad: web_scenario: Silence type warnings when using requests-mock.