Page MenuHomeSoftware Heritage

tox: Disable coverage in py3-minimal
ClosedPublic

Authored by vlorentz on May 11 2021, 11:24 AM.

Details

Summary

If run after py3-full, it overwrites the full coverage info, so most lines
are incorrectly reported as uncovered in Phabricator diffs.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5735 (id=20480)

Could not rebase; Attempt merge onto 31cb72e9f0...

Updating 31cb72e..96cc355
Fast-forward
 swh/model/hashutil.py               |  55 +++++++++---------
 swh/model/identifiers.py            | 107 ++++++++++++++++++++++--------------
 swh/model/tests/test_identifiers.py |  56 ++++++++++++++-----
 tox.ini                             |  10 ++--
 4 files changed, 140 insertions(+), 88 deletions(-)
Changes applied before test
commit 96cc355d202ef53770bbfa9d4a92d0f220dfd856
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 11 11:24:43 2021 +0200

    tox: Disable coverage in py3-minimal
    
    If run after py3-full, it overwrites the full coverage info, so most lines
    are incorrectly reported as uncovered in Phabricator diffs.

commit 8c904dc6af617d595c1295b80c3976ea1861b92f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 30 12:24:00 2021 +0200

    identifiers: Expose git_object instead of manifest
    
    The git_object is what will be actually useful to the vault.
    
    It's also easier to test, because test_identifier.py has the
    entire git_object in its test data.

commit 523ab642bb48491f8e09fb61cc32a9e11420b556
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 30 11:26:32 2021 +0200

    identifiers: Expose manifest computation
    
    Before this commit, manifests were only computed internally before
    hashing, so they were not available to outside modules.
    
    This makes testing the module very painful, because identifier
    functions can only be tested by checking the hash; so test failures
    did not show mismatches between the computed manifest and
    the expected one.
    
    Additionally, the 'git bare cooker' of the vault is likely to use
    these as well, as it needs to format git objects in the same format.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/337/ for more details.

This revision is now accepted and ready to land.May 11 2021, 11:55 AM
This revision was automatically updated to reflect the committed changes.