Differential D5705

Fix flaky test_grab_ready_* tests
ClosedPublic
Actions

Authored by vlorentz on May 6 2021, 4:17 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCHfe9d94905a86: Fix flaky test_grab_ready_* tests

Summary

Hopefully? eg. see https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/341/console

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 6 2021, 4:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 6 2021, 4:17 PM

Build has FAILED

Patch application report for D5705 (id=20362)

Rebasing onto 8a892e2f86...

Current branch diff-target is up to date.

Changes applied before test

commit 205a6396f7112069d37bf819e806380daf16f90c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 6 16:16:50 2021 +0200

    Fix flaky test_grab_ready_* tests

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/342/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/342/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 6 2021, 4:19 PM

Harbormaster failed remote builds in B21343: Diff 20362!

fix

Build is green

Patch application report for D5705 (id=20363)

Rebasing onto 8a892e2f86...

Current branch diff-target is up to date.

Changes applied before test

commit fe9d94905a86f3863de0c06b877687f665b6146e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 6 16:16:50 2021 +0200

    Fix flaky test_grab_ready_* tests

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/343/ for more details.

Harbormaster completed remote builds in B21344: Diff 20363.May 6 2021, 4:24 PM

vlorentz requested review of this revision.May 6 2021, 4:24 PM

hopefully ;)

ardumont accepted this revision.May 6 2021, 4:54 PM

This revision is now accepted and ready to land.May 6 2021, 4:54 PM

Closed by commit rDSCHfe9d94905a86: Fix flaky test_grab_ready_* tests (authored by vlorentz). · Explain WhyMay 6 2021, 4:55 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSCHfe9d94905a86: Fix flaky test_grab_ready_* tests.