Differential D5697

Blacklist attr 21.1.0
ClosedPublic
Actions

Authored by vlorentz on May 6 2021, 2:18 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMOD31cb72e9f059: Blacklist attr 21.1.0

Summary

There is a regression that breaks attr.evolve() when updating attributes
that contain an attr class; which we use (eg. for Person or TimestampWithTimezone).

v21.2.0 is expected to fix the issue, but won't be released immediately:
https://github.com/python-attrs/attrs/issues/804#issuecomment-833471190

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21325
Build 33118: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 33117: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 6 2021, 2:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 6 2021, 2:18 PM

Build is green

Patch application report for D5697 (id=20342)

Rebasing onto df036ef1c3...

Current branch diff-target is up to date.

Changes applied before test

commit 31cb72e9f059cd873bbedc26fb4385a1c8c2bab3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu May 6 14:17:55 2021 +0200

    Blacklist attr 21.1.0
    
    There is a regression that breaks attr.evolve() when updating attributes
    that contain an attr class; which we use (eg. for Person or TimestampWithTimezone).
    
    v21.2.0 is expected to fix the issue, but won't be released immediately:
    https://github.com/python-attrs/attrs/issues/804#issuecomment-833471190

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/333/ for more details.

Harbormaster completed remote builds in B21325: Diff 20342.May 6 2021, 2:21 PM

vlorentz requested review of this revision.May 6 2021, 2:21 PM

ardumont accepted this revision.May 6 2021, 2:30 PM

This revision is now accepted and ready to land.May 6 2021, 2:30 PM

Closed by commit rDMOD31cb72e9f059: Blacklist attr 21.1.0 (authored by vlorentz). · Explain WhyMay 6 2021, 2:30 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMOD31cb72e9f059: Blacklist attr 21.1.0.