Differential D5667

assets/webapp: Add utility function to check if a user is logged in
ClosedPublic
Actions

Authored by anlambert on May 4 2021, 11:53 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3272: Authenticated users should be able to browse their save code now requests

Commits

rDWAPPSa1e05515b912: assets/webapp: Add utility function to check if a user is logged in

Summary

It enables to check if a user is currently authenticated from javascript code.

Related to T3272

Diff Detail

Repository

rDWAPPS Web applications

Branch

js-is-user-logged-in

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21228
Build 32955: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32954: arc lint + arc unit

Event Timeline

anlambert created this revision.May 4 2021, 11:53 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 4 2021, 11:53 AM

lgtm, one question inline.

swh/web/templates/layout.html
59	Is this a hidden field?

ardumont accepted this revision.May 4 2021, 11:58 AM

This revision is now accepted and ready to land.May 4 2021, 11:58 AM

Build is green

Patch application report for D5667 (id=20240)

Rebasing onto 97d077ffd3...

Current branch diff-target is up to date.

Changes applied before test

commit a1e05515b912402b9b1e399ecb312ef4352db064
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue May 4 11:49:47 2021 +0200

    assets/webapp: Add utility function to check if a user is logged in
    
    Related to T3272

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/766/ for more details.

Harbormaster completed remote builds in B21228: Diff 20240.May 4 2021, 12:02 PM

anlambert added inline comments.May 4 2021, 12:02 PM

swh/web/templates/layout.html
59	Nope, see https://docs.djangoproject.com/en/3.2/ref/templates/builtins/#json-script This a django template filter I did not know of that dumps JSON into a script tag.