Page MenuHomeSoftware Heritage
Differential D5655

assets/webapp-utils: Add lowercase validator for core SWHIDs
ClosedPublic
Actions

Authored by anlambert on Apr 30 2021, 2:43 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T3298: Consider making SWHID handling case insensitive
Commits
rDWAPPS619576342307: assets/webapp-utils: Add lowercase validator for core SWHIDs
Summary

When entering a SWHID in a search input, check its core part is in lowercase
and do not validate the form if it is not.

An error message clearly indicating that core SWHID should be in lowercase
will then be displayed.

Nevertheless, core SWHID with uppercase chars in it will still be automatically
fixed when provided to its resolve URL /<swhid>

Related to T3298

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 30 2021, 2:43 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 30 2021, 2:43 PM
swh-public-ci added a comment.Apr 30 2021, 2:52 PM

Build is green

Patch application report for D5655 (id=20194)

Rebasing onto 03cfd89a1d...

Current branch diff-target is up to date.
Changes applied before test
commit 9d4fe4aa6cba0d49c09827239723b7590880ef83
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:39:13 2021 +0200

    assets/webapp-utils: Do not validate core SWHIDs with upperchase chars
    
    When entering a SWHID in a search input, check its core part is in lowercase
    and do not validate the form if it is not.
    
    An error message clearly indicating that core SWHID should be in lowercase
    will then be displayed.
    
    Nevertheless, core SWHID with uppercase chars in it will still be automatically
    fixed when provided to its resolve URL /<swhid>
    
    Related to T3298

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/753/ for more details.

Harbormaster completed remote builds in B21183: Diff 20194.Apr 30 2021, 2:52 PM
anlambert requested review of this revision.Apr 30 2021, 2:52 PM
anlambert retitled this revision from assets/webapp-utils: Do not validate core SWHIDs with upperchase chars to assets/webapp-utils: Do not validate core SWHIDs with uppercase chars.Apr 30 2021, 2:53 PM
anlambert updated this revision to Diff 20195.Apr 30 2021, 2:54 PM

Fix typo

swh-public-ci added a comment.Apr 30 2021, 3:02 PM

Build has FAILED

Patch application report for D5655 (id=20195)

Rebasing onto 03cfd89a1d...

Current branch diff-target is up to date.
Changes applied before test
commit 1652204157ca01024f6bc03adde4e14c78bf7a3c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:39:13 2021 +0200

    assets/webapp-utils: Do not validate core SWHIDs with uppercase chars
    
    When entering a SWHID in a search input, check its core part is in lowercase
    and do not validate the form if it is not.
    
    An error message clearly indicating that core SWHID should be in lowercase
    will then be displayed.
    
    Nevertheless, core SWHID with uppercase chars in it will still be automatically
    fixed when provided to its resolve URL /<swhid>
    
    Related to T3298

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/754/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/754/console

Harbormaster failed remote builds in B21184: Diff 20195!Apr 30 2021, 3:02 PM
swh-public-ci added a comment.Apr 30 2021, 3:43 PM

Build has FAILED

Patch application report for D5655 (id=20195)

Rebasing onto 03cfd89a1d...

Current branch diff-target is up to date.
Changes applied before test
commit 1652204157ca01024f6bc03adde4e14c78bf7a3c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:39:13 2021 +0200

    assets/webapp-utils: Do not validate core SWHIDs with uppercase chars
    
    When entering a SWHID in a search input, check its core part is in lowercase
    and do not validate the form if it is not.
    
    An error message clearly indicating that core SWHID should be in lowercase
    will then be displayed.
    
    Nevertheless, core SWHID with uppercase chars in it will still be automatically
    fixed when provided to its resolve URL /<swhid>
    
    Related to T3298

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/757/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/757/console

anlambert updated this revision to Diff 20197.Apr 30 2021, 4:32 PM

Update commit message and display valid SWHID in error message.

anlambert retitled this revision from assets/webapp-utils: Do not validate core SWHIDs with uppercase chars to assets/webapp-utils: Add lowercase validator for core SWHIDs.Apr 30 2021, 4:32 PM
anlambert edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Apr 30 2021, 4:41 PM

Build is green

Patch application report for D5655 (id=20197)

Rebasing onto 03cfd89a1d...

Current branch diff-target is up to date.
Changes applied before test
commit 1d61e250f933a0a79945e0aa45fccbd4f05b7ed3
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:39:13 2021 +0200

    assets/webapp-utils: Add lowercase validator for core SWHIDs
    
    When entering a SWHID in a search input, check its core part is in lowercase
    and do not validate the form if it is not.
    
    An error message clearly indicating that core SWHID should be in lowercase
    will then be displayed.
    
    Nevertheless, core SWHID with uppercase chars in it will still be automatically
    fixed when provided to its resolve URL /<swhid>
    
    Related to T3298

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/758/ for more details.

Harbormaster completed remote builds in B21186: Diff 20197.Apr 30 2021, 4:41 PM
anlambert updated this revision to Diff 20200.Apr 30 2021, 5:15 PM

Rebase

ardumont accepted this revision.Apr 30 2021, 5:20 PM
ardumont added a subscriber: ardumont.

lgtm (i think)

This revision is now accepted and ready to land.Apr 30 2021, 5:20 PM
swh-public-ci added a comment.Apr 30 2021, 5:24 PM

Build is green

Patch application report for D5655 (id=20200)

Rebasing onto 450988b969...

Current branch diff-target is up to date.
Changes applied before test
commit 6195763423075074d875853cc098977eac6ace86
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Apr 30 14:39:13 2021 +0200

    assets/webapp-utils: Add lowercase validator for core SWHIDs
    
    When entering a SWHID in a search input, check its core part is in lowercase
    and do not validate the form if it is not.
    
    An error message clearly indicating that core SWHID should be in lowercase
    will then be displayed.
    
    Nevertheless, core SWHID with uppercase chars in it will still be automatically
    fixed when provided to its resolve URL /<swhid>
    
    Related to T3298

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/760/ for more details.

Harbormaster completed remote builds in B21189: Diff 20200.Apr 30 2021, 5:24 PM
Closed by commit rDWAPPS619576342307: assets/webapp-utils: Add lowercase validator for core SWHIDs (authored by anlambert). · Explain WhyApr 30 2021, 5:25 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS619576342307: assets/webapp-utils: Add lowercase validator for core SWHIDs.

Revision Contents
Changeset List

PathSize
assets/
src/
bundles/
webapp/
33 lines
cypress/
integration/
33 lines

Diff 20201

View Options

assets/src/bundles/webapp/webapp-utils.js

Loading...
View Options

cypress/integration/origin-search.spec.js

Loading...
About · Developer information · Legal