- reflect swh-model changes
- make mypy pass
Details
Details
- Reviewers
zack - Group Reviewers
Reviewers - Commits
- rDTSCNed78dce5eb6e: add algorithms timings in results
Diff Detail
Diff Detail
- Repository
- rDTSCN Code scanner
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/121/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/121/console
Comment Actions
the fact that algo_min is treated differently than other cases is horrible :-P, but it's not new in this diff, so ok :)
also, in the requirements you should probably put what's the minimum version of swh.core that you need, but that too is not a big deal
so i'm accepting this, correct what you can before merging (into the branch), but nothing is blocking
Comment Actions
- minimum required version for swh-model
- treat algo_min in the same way as other cases
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/122/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/122/console