graph: Ensure tests pass with all requests-mock versions
ClosedPublic
Actions

Authored by anlambert on Apr 28 2021, 3:30 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS50c6b1f01fb6: tests/api/graph: Ensure tests pass with all requests-mock versions

Summary

requests-mock recently changed its way to match URLs, paths are now
quoted when registering mocked URLs.

As Web API graph endpoint send HTTP requests to the Graph service
with SWHIDs in URL paths (containing ':' characters), those must
also be quoted or recent requests-mock will not find the registered
mocked URLs.

Also ensure tests still pass with older requests-mock versions.

Of course, I have tested that the endpoint still works as expected without mocked responses.

See https://github.com/jamielennox/requests-mock/commit/f072845

Diff Detail

Repository

rDWAPPS Web applications

Branch

graph-requests-mock-fixes

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21104
Build 32753: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32752: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 28 2021, 3:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 28 2021, 3:30 PM

anlambert edited the summary of this revision. (Show Details)Apr 28 2021, 3:31 PM

ardumont published this revision for review.Apr 28 2021, 3:33 PM

ardumont added a child revision: D5624: Fix malformatted date value when null.

ardumont mentioned this in D5624: Fix malformatted date value when null.

Thanks.

This should fix the latest master build failure (which also fails other diffs on the webapp since the new requests mock release)

This revision is now accepted and ready to land.Apr 28 2021, 3:36 PM

Build is green

Patch application report for D5637 (id=20112)

Rebasing onto 11c737df9b...

Current branch diff-target is up to date.

Changes applied before test

commit 50c6b1f01fb6de10498a89e37e901382b773eeeb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 28 15:25:24 2021 +0200

    tests/api/graph: Ensure tests pass with all requests-mock versions
    
    requests-mock recently changed its way to match URLs, paths are now
    quoted when registering mocked URLs.
    
    As Web API graph endpoint send HTTP requests to the Graph service
    with SWHIDs in URL paths (containing ':' characters), those must
    also be quoted or recent requests-mock will not find the registered
    mocked URLs.
    
    Also ensure tests still pass with older requests-mock versions.
    
    See https://github.com/jamielennox/requests-mock/commit/f072845

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/743/ for more details.

Harbormaster completed remote builds in B21104: Diff 20112.Apr 28 2021, 3:38 PM

Closed by commit rDWAPPS50c6b1f01fb6: tests/api/graph: Ensure tests pass with all requests-mock versions (authored by anlambert). · Explain WhyApr 28 2021, 3:41 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS50c6b1f01fb6: tests/api/graph: Ensure tests pass with all requests-mock versions.

anlambert added a reverting change: D5651: Revert "tests/api/graph: Ensure tests pass with all requests-mock versions".Apr 30 2021, 11:41 AM

anlambert added a reverting change: rDWAPPS03cfd89a1d19: Revert "tests/api/graph: Ensure tests pass with all requests-mock versions".Apr 30 2021, 11:53 AM