origin_save: Explicitely populate SaveAuthorizedOrigin table
ClosedPublic
Actions

Authored by anlambert on Apr 22 2021, 3:32 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3266: Improve save code now failed/uneventful status reporting

Commits

rDWAPPSa65bc357b707: pytest.ini: Silent annoying warning
rDWAPPS2a35b545b882: tests/api/origin_save: Explicitely populate SaveAuthorizedOrigin table

Summary

The use of django-test-migrations have some unexpected side effect
when building the debian package of swh-web, some default data
added to the SaveAuthorizedOrigin table in initial migrations
end up missing.

So ensure to explicitely fill that table with needed tests data
to avoid some test failures.

Related to T3266

I also added a commit to silent a distutils related warning.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 22 2021, 3:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 22 2021, 3:32 PM

Thanks.

pytest.ini
11 ↗	(On Diff #19924)	ah nice, thx.

ardumont accepted this revision.Apr 22 2021, 3:34 PM

This revision is now accepted and ready to land.Apr 22 2021, 3:34 PM

Build is green

Patch application report for D5575 (id=19924)

Rebasing onto 85253bc88f...

Current branch diff-target is up to date.

Changes applied before test

commit a65bc357b70718025474cf3be1dbec8f9113a5d8
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 22 15:31:02 2021 +0200

    pytest.ini: Silent annoying warning
    
    Pytest report when building debian package is not easily exploitable
    without silenting that warning.

commit 2a35b545b88278fb427756d4884b588bcd347455
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 22 15:27:02 2021 +0200

    tests/api/origin_save: Explicitely populate SaveAuthorizedOrigin table
    
    The use of django-test-migrations have some unexpected side effect
    when building the debian package of swh-web, some default data
    added to the SaveAuthorizedOrigin table in initial migrations
    end up missing.
    
    So ensure to explicitely fill that table with needed tests data
    to avoid some test failures.
    
    Related to T3266

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/716/ for more details.

Harbormaster completed remote builds in B20929: Diff 19924.Apr 22 2021, 3:39 PM

Closed by commit rDWAPPS2a35b545b882: tests/api/origin_save: Explicitely populate SaveAuthorizedOrigin table (authored by anlambert). · Explain WhyApr 22 2021, 3:40 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS2a35b545b882: tests/api/origin_save: Explicitely populate SaveAuthorizedOrigin table.

anlambert added a commit: rDWAPPSa65bc357b707: pytest.ini: Silent annoying warning.