Page MenuHomeSoftware Heritage

Parse task_ids before calling set_status_tasks.
ClosedPublic

Authored by vlorentz on Apr 20 2021, 11:00 AM.

Details

Summary

So errors on the CLI side do not trigger an exception on the server,
such as https://sentry.softwareheritage.org/share/issue/396669f829d148c09ec3a313df905fd4/
(I assume it was called from the CLI, because it's the only way to pass it more
than one argument)

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5560 (id=19857)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit ae1b467f3026b3a11030bfd86804274f489ec1b3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 20 10:59:53 2021 +0200

    Parse task_ids before calling set_status_tasks.
    
    So errors on the CLI side do not trigger an exception on the server

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/328/ for more details.

anlambert added a subscriber: anlambert.

Looks good to me.

swh/scheduler/cli/task.py
1

2021

This revision is now accepted and ready to land.Apr 20 2021, 11:15 AM
This revision was landed with ongoing or failed builds.Apr 20 2021, 11:20 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D5560 (id=19858)

Rebasing onto 4e06bcd71e...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-329-D5560.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/329/ for more details.