Differential D5528

sql/Makefile: Also call dropdb prior createdb when using pifpaf
ClosedPublic
Actions

Authored by anlambert on Apr 14 2021, 6:42 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTOb999952e076b: sql/Makefile: Also call dropdb prior createdb when using pifpaf

Summary

Now that PGDATABASE value from pifpaf is used, that call is now needed
otherwise the overall swh doc build in development mode fails.

See https://jenkins.softwareheritage.org/job/DDOC/job/dev/5512/console

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 14 2021, 6:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 14 2021, 6:42 PM

Build is green

Patch application report for D5528 (id=19714)

Rebasing onto 1bacea5c44...

Current branch diff-target is up to date.

Changes applied before test

commit b999952e076b532ae14895c9bed2919990c619ce
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 14 18:39:49 2021 +0200

    sql/Makefile: Also call dropdb prior createdb when using pifpaf
    
    Now that PGDATABASE value from pifpaf is used, that call is now needed
    otherwise the overall swh doc build in development mode fails.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1260/ for more details.

Harbormaster completed remote builds in B20739: Diff 19714.Apr 14 2021, 6:47 PM

anlambert requested review of this revision.Apr 14 2021, 6:47 PM

ardumont accepted this revision.Apr 14 2021, 6:50 PM

This revision is now accepted and ready to land.Apr 14 2021, 6:50 PM

Closed by commit rDSTOb999952e076b: sql/Makefile: Also call dropdb prior createdb when using pifpaf (authored by anlambert). · Explain WhyApr 14 2021, 6:50 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSTOb999952e076b: sql/Makefile: Also call dropdb prior createdb when using pifpaf.