Differential D551

Add a function to retrieve a full snapshot
ClosedPublic
Actions

Authored by olasd on Oct 18 2018, 4:57 PM.

Tags

None

Subscribers

Details

Reviewers

Commits

rDSTOCad922485bf1c: Add a function to retrieve a full snapshot
R65:ad922485bf1c: Add a function to retrieve a full snapshot
rDSTOad922485bf1c: Add a function to retrieve a full snapshot

Summary

This function wraps the paginating branch listing API to do its work. It's in
swh.storage.algos because it should be done client-side rather than server-side.

The tests are fairly simple, and mostly add a bunch of tooling around hypothesis
to generate data that conforms to the swh data schema. Those things could
probably be adequately moved to a new submodule of swh.model.

Test Plan

new tests added

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 18 2018, 4:57 PM

Harbormaster completed remote builds in B1682: Diff 1695.Oct 18 2018, 4:57 PM

LGTM. The hypothesis module looks really interesting for writing better tests, I should document myself on it.

This revision is now accepted and ready to land.Oct 18 2018, 5:16 PM

Closed by commit rDSTOad922485bf1c: Add a function to retrieve a full snapshot (authored by olasd). · Explain WhyOct 18 2018, 5:56 PM

This revision was automatically updated to reflect the committed changes.

Nice

Especially the 'generator' part in tests ;)

Revision Contents
Changeset List

Path

Size

1 line

requirements-test.txt

1 line

swh/

storage/

algos/

31 lines

tests/

algos/

test_snapshot.py

125 lines

Diff 1701

.gitignore

Loading...

requirements-test.txt

Loading...

swh/storage/algos/snapshot.py

Loading...

swh/storage/tests/algos/test_snapshot.py

Loading...