Page MenuHomeSoftware Heritage

Define pytest_plugins at the root to support pytest 4.0
ClosedPublic

Authored by vlorentz on Apr 13 2021, 8:36 PM.

Details

Summary
Defining 'pytest_plugins' in a non-top-level conftest is no longer supported:
It affects the entire test suite instead of just below the conftest as expected.
  /home/dev/swh-environment/swh-web/swh/web/tests/conftest.py
Please move it to a top level conftest file at the rootdir:
  /home/dev/swh-environment/swh-web
For more information, visit:
  https://docs.pytest.org/en/stable/deprecations.html#pytest-plugins-in-non-top-level-conftest-files

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5504 (id=19664)

Rebasing onto 6fa50083a1...

Current branch diff-target is up to date.
Changes applied before test
commit a4c15fb3098536fa747648e78183848b17edec36
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 13 20:35:55 2021 +0200

    Define pytest_plugins at the root to support pytest 4.0
Defining 'pytest_plugins' in a non-top-level conftest is no longer supported:
It affects the entire test suite instead of just below the conftest as expected.
  /home/dev/swh-environment/swh-web/swh/web/tests/conftest.py
Please move it to a top level conftest file at the rootdir:
  /home/dev/swh-environment/swh-web
For more information, visit:
  https://docs.pytest.org/en/stable/deprecations.html#pytest-plugins-in-non-top-level-conftest-files
```
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/677/ for more details.
This revision is now accepted and ready to land.Apr 14 2021, 9:25 AM
This revision was landed with ongoing or failed builds.Apr 15 2021, 10:14 AM
This revision was automatically updated to reflect the committed changes.

Build has FAILED

Patch application report for D5504 (id=19723)

Rebasing onto 5d74b78688...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-686-D5504.
Changes applied before test

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/686/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/686/console