Details

Reviewers

Group Reviewers

Commits

rDWAPPScf69ace02851: Move assets folder out of the Python source tree

Summary

Been a while since I wanted to move that web assets folder out of
the Python source tree, this should have been organized this way
since the beginning.

As a consequence the assets sources are not included in the distribution
wheel but are of course still present in the source tarball.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 7 2021, 2:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2021, 2:55 PM

Build has FAILED

Patch application report for D5441 (id=19454)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.

Changes applied before test

commit c06c1662f219a3eeb973d393331aa89e4b8d44bd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/656/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/656/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2021, 3:03 PM

Harbormaster failed remote builds in B20498: Diff 19454!

Update conftest.py to get webpack bundle names from compiled asset
filenames when using tox since the assets folder is no more included
in the distribution wheel.

Build has FAILED

Patch application report for D5441 (id=19457)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.

Changes applied before test

commit b4aad1657034bea217db1c5a0055403704883960
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/657/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/657/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2021, 3:32 PM

Harbormaster failed remote builds in B20501: Diff 19457!

Fix if statement in conftest.py

Build has FAILED

Patch application report for D5441 (id=19458)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.

Changes applied before test

commit e00e3ba7d81a90be5f8ae129346c21789016167f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/658/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/658/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 7 2021, 4:18 PM

Harbormaster failed remote builds in B20502: Diff 19458!

Build was aborted

Patch application report for D5441 (id=19458)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.

Changes applied before test

commit e00e3ba7d81a90be5f8ae129346c21789016167f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/659/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/659/console

Build was aborted

Patch application report for D5441 (id=19458)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.

Changes applied before test

commit e00e3ba7d81a90be5f8ae129346c21789016167f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/660/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/660/console

Another try to fix tox build on Jenkins

anlambert edited the summary of this revision. (Show Details)Apr 7 2021, 4:51 PM

Build is green

Patch application report for D5441 (id=19464)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.

Changes applied before test

commit cf69ace02851442c6ac62d9ff3bd855169636989
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/661/ for more details.

Harbormaster completed remote builds in B20507: Diff 19464.Apr 7 2021, 4:56 PM

anlambert requested review of this revision.Apr 7 2021, 4:56 PM

vlorentz accepted this revision.Apr 7 2021, 5:14 PM

This revision is now accepted and ready to land.Apr 7 2021, 5:14 PM

Closed by commit rDWAPPScf69ace02851: Move assets folder out of the Python source tree (authored by anlambert). · Explain WhyApr 7 2021, 5:21 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPScf69ace02851: Move assets folder out of the Python source tree.

Move assets folder out of the Python source treeClosedPublicActions

Details

Diff Detail

Event Timeline

Patch application report for D5441 (id=19454)

Changes applied before test

Patch application report for D5441 (id=19457)

Changes applied before test

Patch application report for D5441 (id=19458)

Changes applied before test

Patch application report for D5441 (id=19458)

Changes applied before test

Patch application report for D5441 (id=19458)

Changes applied before test

Patch application report for D5441 (id=19464)

Changes applied before test

Large Diff

Revision ContentsChangeset List

Diff 19471

.pre-commit-config.yaml

MANIFEST.in

assets/config/.bootstraprc

assets/config/.eslintignore

assets/config/.eslintrc

assets/config/bootstrap-pre-customize.scss

assets/config/webpack-plugins/dump-highlightjs-languages-data-plugin.js

assets/config/webpack-plugins/fix-swh-source-maps-webpack-plugin.js

assets/config/webpack-plugins/fix-webpack-stats-format-plugin.js

assets/config/webpack-plugins/generate-weblabels-webpack-plugin/README.md

assets/config/webpack-plugins/generate-weblabels-webpack-plugin/index.js

assets/config/webpack-plugins/generate-weblabels-webpack-plugin/jslicenses.ejs

assets/config/webpack-plugins/generate-weblabels-webpack-plugin/plugin-options-schema.json

assets/config/webpack-plugins/generate-weblabels-webpack-plugin/spdx-licenses-mapping.js

assets/config/webpack.config.development.js

assets/config/webpack.config.production.js

assets/src/bundles/admin/deposit.js

assets/src/bundles/admin/index.js

assets/src/bundles/admin/origin-save.js

assets/src/bundles/auth/auth.css

assets/src/bundles/auth/index.js

assets/src/bundles/browse/breadcrumbs.css

assets/src/bundles/browse/browse-utils.js

assets/src/bundles/browse/browse.css

assets/src/bundles/browse/content.css

assets/src/bundles/browse/index.js

assets/src/bundles/browse/origin-search.js

assets/src/bundles/browse/snapshot-navigation.css

assets/src/bundles/browse/snapshot-navigation.js

assets/src/bundles/browse/swhid-utils.js

assets/src/bundles/origin/index.js

assets/src/bundles/origin/visits-calendar.js

assets/src/bundles/origin/visits-histogram.js

assets/src/bundles/origin/visits-reporting.css

assets/src/bundles/origin/visits-reporting.js

assets/src/bundles/revision/diff-panel.ejs

assets/src/bundles/revision/diff-utils.js

assets/src/bundles/revision/index.js

assets/src/bundles/revision/log-utils.js

assets/src/bundles/revision/revision.css

assets/src/bundles/save/index.js

assets/src/bundles/vault/index.js

assets/src/bundles/vault/vault-create-tasks.js

assets/src/bundles/vault/vault-table-row.ejs

assets/src/bundles/vault/vault-ui.js

assets/src/bundles/vault/vault.css

assets/src/bundles/vendors/datatables.css

assets/src/bundles/vendors/elementsfrompoint-polyfill.js

assets/src/bundles/vendors/index.js

assets/src/bundles/webapp/badges.js

assets/src/bundles/webapp/breadcrumbs.css

assets/src/bundles/webapp/code-highlighting.js

assets/src/bundles/webapp/history-counters.css

assets/src/bundles/webapp/history-counters.js

assets/src/bundles/webapp/index.js

assets/src/bundles/webapp/math-typesetting.js

assets/src/bundles/webapp/notebook-rendering.js

assets/src/bundles/webapp/notebook.css

assets/src/bundles/webapp/pdf-rendering.js

assets/src/bundles/webapp/readme-rendering.js

assets/src/bundles/webapp/sentry.js

Move assets folder out of the Python source tree
ClosedPublic
Actions

Revision Contents
Changeset List