Page MenuHomeSoftware Heritage

Move assets folder out of the Python source tree
ClosedPublic

Authored by anlambert on Wed, Apr 7, 2:55 PM.

Details

Summary

Been a while since I wanted to move that web assets folder out of
the Python source tree, this should have been organized this way
since the beginning.

As a consequence the assets sources are not included in the distribution
wheel but are of course still present in the source tarball.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D5441 (id=19454)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.
Changes applied before test
commit c06c1662f219a3eeb973d393331aa89e4b8d44bd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/656/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/656/console

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Apr 7, 3:03 PM
Harbormaster failed remote builds in B20498: Diff 19454!

Update conftest.py to get webpack bundle names from compiled asset
filenames when using tox since the assets folder is no more included
in the distribution wheel.

Build has FAILED

Patch application report for D5441 (id=19457)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.
Changes applied before test
commit b4aad1657034bea217db1c5a0055403704883960
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/657/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/657/console

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Apr 7, 3:32 PM
Harbormaster failed remote builds in B20501: Diff 19457!

Fix if statement in conftest.py

Build has FAILED

Patch application report for D5441 (id=19458)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.
Changes applied before test
commit e00e3ba7d81a90be5f8ae129346c21789016167f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/658/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/658/console

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Apr 7, 4:18 PM
Harbormaster failed remote builds in B20502: Diff 19458!

Build was aborted

Patch application report for D5441 (id=19458)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.
Changes applied before test
commit e00e3ba7d81a90be5f8ae129346c21789016167f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/659/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/659/console

Build was aborted

Patch application report for D5441 (id=19458)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.
Changes applied before test
commit e00e3ba7d81a90be5f8ae129346c21789016167f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/660/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/660/console

Another try to fix tox build on Jenkins

Build is green

Patch application report for D5441 (id=19464)

Rebasing onto 0e1a506460...

Current branch diff-target is up to date.
Changes applied before test
commit cf69ace02851442c6ac62d9ff3bd855169636989
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 7 12:16:32 2021 +0200

    Move assets folder out of the Python source tree
    
    This is more consistent to organize web assets sources and
    configuration this way.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/661/ for more details.

This revision is now accepted and ready to land.Wed, Apr 7, 5:14 PM