Fix test_rst_to_html to work with docutils 0.17
AbandonedPublic
Actions

Authored by vlorentz on Apr 7 2021, 12:21 PM.

Details

Reviewers

None

Group Reviewers

Summary

docutils now produces <section instead of <div class="section".
This does not affect us because we don't have any style on div.section,
so it just needs this test update.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20481
Build 31789: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31788: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 7 2021, 12:21 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2021, 12:21 PM

Build is green

Patch application report for D5434 (id=19432)

Rebasing onto fe53dbee8e...

First, rewinding head to replay your work on top of it...
Applying: Fix test_rst_to_html to work with docutils 0.17

Changes applied before test

commit 9a2ad86ddbb54294456dd67a3223392dbd331358
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 7 12:21:05 2021 +0200

    Fix test_rst_to_html to work with docutils 0.17
    
    docutils now produces <section instead of <div class="section".
    This does not affect us because we don't have any style on div.section,
    so it just needs this test update.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/651/ for more details.

Harbormaster completed remote builds in B20481: Diff 19432.Apr 7 2021, 12:28 PM

vlorentz requested review of this revision.Apr 7 2021, 12:28 PM

I also pushed a fix in D5435, looks like we spot the issue at the same time.

My fix is simpler by ensuring the input rst produces the same HTML ouput regarding the docutils version.

I can accept the diff though as it was pushed first, your choice.

vlorentz abandoned this revision.Apr 7 2021, 12:38 PM