Differential D542

move sql files in the python package and update tests according to D538
ClosedPublic
Actions

Authored by douardda on Oct 16 2018, 11:21 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T1265: kill swh-storage-testdata [was: make swh-storage-testdata a python package]

Commits

rDVAUdd9b7660a3b6: tests: make db-related tests use sql files from the package
rDVAUeca350c45715: sql: move sql files in the package
rDVAU3aafd23d44cd: tests: storage's StorageTestFixture now inherit from SingleDbTestFixture

Summary

Also depends on swh-storage's D540.

This refactoring also requires a small change in vault's swh-schema.sql:

create the dbversion table only if needed, otherwise this sql 
cannot be executed without error on the top of storages' db 
schema.

Related to T1265.

Test Plan

tests should pass provided that D538 and D540 are applied.

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

t1265-kill-testdata

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1667
Build 2011: arc lint + arc unit

Event Timeline

douardda created this revision.Oct 16 2018, 11:21 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 16 2018, 11:21 PM

Harbormaster completed remote builds in B1667: Diff 1668.Oct 16 2018, 11:21 PM

ardumont accepted this revision.Oct 17 2018, 11:26 AM

This revision is now accepted and ready to land.Oct 17 2018, 11:26 AM

Closed by commit rDVAU3aafd23d44cd: tests: storage's StorageTestFixture now inherit from SingleDbTestFixture (authored by douardda). · Explain WhyOct 17 2018, 4:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sql/

swh-vault-schema.sql

	swh/	vault/	sql/
			sql/

	30-swh-schema.sql
	swh-vault-schema.sql

2 lines

swh/

vault/

tests/

5 lines

4 lines

4 lines

4 lines

29 lines

Diff 1668

View Options

sql/swh-vault-schema.sql

View Options

swh/vault/sql/30-swh-schema.sql

View Options

swh/vault/tests/init.py

View Options

swh/vault/tests/test_backend.py

View Options

swh/vault/tests/test_cache.py

View Options

swh/vault/tests/test_cookers.py

View Options

swh/vault/tests/vault_testing.py

move sql files in the python package and update tests according to D538ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1668

sql/swh-vault-schema.sql

swh/vault/sql/30-swh-schema.sql

swh/vault/tests/__init__.py

swh/vault/tests/test_backend.py

swh/vault/tests/test_cache.py

swh/vault/tests/test_cookers.py

swh/vault/tests/vault_testing.py

move sql files in the python package and update tests according to D538
ClosedPublic
Actions

Revision Contents
Changeset List

swh/vault/tests/init.py