Page MenuHomeSoftware Heritage

package loaders: Stop reading/writing Revision.metadata
ClosedPublic

Authored by vlorentz on Tue, Apr 6, 1:49 PM.

Details

Summary

They already write it with raw_extrinsic_metadata_add/extid_add,
and read it with extid_get_*.

This code was only kept for compatibility while we were migrating
the extids. This is now done, so this code is useless.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5423 (id=19380)

Could not rebase; Attempt merge onto ec5a76c6d9...

Updating ec5a76c..8267022
Fast-forward
 docs/README.rst                                  |   1 +
 docs/index.rst                                   |   2 +
 docs/package-loader-tutorial.rst                 | 650 +++++++++++++++++++++++
 swh/loader/package/archive/loader.py             |  14 -
 swh/loader/package/archive/tests/test_archive.py |  32 --
 swh/loader/package/cran/loader.py                |  14 +-
 swh/loader/package/debian/loader.py              |  23 -
 swh/loader/package/debian/tests/test_debian.py   | 150 ------
 swh/loader/package/deposit/loader.py             |   7 -
 swh/loader/package/deposit/tests/test_deposit.py |  65 +--
 swh/loader/package/loader.py                     |  63 +--
 swh/loader/package/nixguix/loader.py             |  22 -
 swh/loader/package/nixguix/tests/test_nixguix.py | 104 +---
 swh/loader/package/npm/loader.py                 |  56 --
 swh/loader/package/npm/tests/test_npm.py         |  67 ---
 swh/loader/package/pypi/loader.py                |  65 ---
 swh/loader/package/pypi/tests/test_pypi.py       |  65 ---
 swh/loader/package/tests/common.py               |  42 --
 swh/loader/package/tests/test_common.py          |  62 ---
 swh/loader/package/tests/test_loader.py          |  45 --
 20 files changed, 660 insertions(+), 889 deletions(-)
 create mode 100644 docs/package-loader-tutorial.rst
 delete mode 100644 swh/loader/package/tests/test_common.py
Changes applied before test
commit 82670226dd2f0c6220944cd8929023ddfb88ae7b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 6 13:48:45 2021 +0200

    package loaders: Stop reading/writing Revision.metadata
    
    They already write it with raw_extrinsic_metadata_add/extid_add,
    and read it with extid_get_*.
    
    This code was only kept for compatibility while we were migrating
    the extids. This is now done, so this code is useless.

commit b6f0bfe0fe4f158b867fba51197ce774a53ac0bd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 2 17:15:47 2021 +0200

    package-loader-tutorial: Add 'Loading metadata' and 'Final words' sections.

commit a17cb565a3fee9fbb70da2bc7f0240f633d20553
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 2 15:39:50 2021 +0200

    package-loader-tutorial: Add 'Making your loader incremental' section

commit cdaad2122951b47ab20ee03e4c97eb67b5716eb1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Apr 2 13:58:29 2021 +0200

    package-loader-tutorial: Add 'Testing your loader' section

commit 0eeb712bb1620df4075b8f7057f86abe4fd149aa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 1 14:14:05 2021 +0200

    Start writing a package loader tutorial.
    
    This contains the basic, from creating files to getting a working
    (but untested and inefficient) loader.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/465/ for more details.

ardumont added a subscriber: ardumont.

lgtm

Awesome, that will simplify new loaders ;)

Note that i'm now wondering if there isn't some of the test data samples that could be cleaned up some more...

This revision is now accepted and ready to land.Tue, Apr 6, 3:04 PM
This revision was landed with ongoing or failed builds.Tue, Apr 6, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D5423 (id=19391)

Rebasing onto d84d68a8bb...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-468-D5423.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/468/ for more details.