Page MenuHomeSoftware Heritage

cran and nixguix: Make known_artifact_to_extid static
ClosedPublic

Authored by vlorentz on Tue, Mar 30, 12:38 PM.

Details

Summary

Like the PyPI and NPM loader.

It allows scripts to use the method without creating a loader instance.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5382 (id=19276)

Rebasing onto e48ced028c...

Current branch diff-target is up to date.
Changes applied before test
commit 7cc11d597f2f4a0ae42a152bb2d0c34ca34a2c57
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 30 12:38:34 2021 +0200

    cran: Make known_artifact_to_extid static
    
    Like the PyPI and NPM loader.
    
    It allows scripts to use the method without creating a loader instance.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/453/ for more details.

Build is green

Patch application report for D5382 (id=19277)

Rebasing onto e48ced028c...

Current branch diff-target is up to date.
Changes applied before test
commit 27e55115483cd8bd4b19f6a4aa9edd2dcb949066
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 30 12:38:34 2021 +0200

    cran and nixguix: Make known_artifact_to_extid static
    
    Like the PyPI and NPM loader.
    
    It allows scripts to use the method without creating a loader instance.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/454/ for more details.

vlorentz retitled this revision from cran: Make known_artifact_to_extid static to cran and nixguix: Make known_artifact_to_extid static.Tue, Mar 30, 12:56 PM
ardumont added a subscriber: ardumont.

ok, as it's unifyng with existing loaders and it does not hurt.

It's not clear whether this is needed or not though.

This revision is now accepted and ready to land.Tue, Mar 30, 2:05 PM