Page MenuHomeSoftware Heritage
Differential D5367

auth: Use generic Django authentication backends from swh-auth
ClosedPublic
Actions

Authored by anlambert on Mar 26 2021, 6:03 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T3150: Move generic django authentication code to swh-auth
Commits
rDWAPPSa42327ff4fd5: auth: Use generic Django authentication backends from swh-auth
Summary

Django authentication backends based on the use of Keycloak and OpenID
Connect have been moved to the swh-auth module and turned into generic
backends in order to easily reuse them in any Django application.

So remove all code and tests that have been moved in swh-auth and
configure swh-web to use the generic authentication backends.

That diff will fail to build until a new swh-auth version is tagged.

Related to T3150

Depends on D5366

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 26 2021, 6:03 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 26 2021, 6:03 PM
swh-public-ci added a comment.Mar 26 2021, 6:04 PM

Build has FAILED

Patch application report for D5367 (id=19223)

Rebasing onto fda3589aa8...

Current branch diff-target is up to date.
Changes applied before test
commit 1584c59ef9f1349bdd7e91eb4bd49bc420e462bb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Mar 25 19:04:28 2021 +0100

    auth: Use generic Django authentication backends from swh-auth
    
    Django authentication backends based on the use of Keycloak and OpenID
    Connect have been moved to the swh-auth module and turned into generic
    backends in order to easily reuse them in any Django application.
    
    So remove all code and tests that have been moved in swh-auth and
    configure swh-web to use the generic authentication backends.
    
    Related to T3150

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/637/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/637/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 26 2021, 6:04 PM
Harbormaster failed remote builds in B20305: Diff 19223!
anlambert updated this revision to Diff 19284.Mar 30 2021, 3:12 PM

Update: Rebase and remove OIDCSessionExpiredMiddleware after its move in swh-auth.

swh-public-ci added a comment.Mar 30 2021, 3:13 PM

Build has FAILED

Patch application report for D5367 (id=19284)

Rebasing onto ffd9fbccbf...

Current branch diff-target is up to date.
Changes applied before test
commit 3a9fbc15d8f8d09089e41e1baf12ab1d526cb20d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Mar 25 19:04:28 2021 +0100

    auth: Use generic Django authentication backends from swh-auth
    
    Django authentication backends and middleware based on the use of
    Keycloak and OpenID Connect have been moved to the swh-auth module
    and  turned into generic ones in order to easily reuse them in any
    Django application.
    
    So remove all code and tests that have been moved in swh-auth and
    configure swh-web to use the generic authentication backends and
    middleware.
    
    Closes T3150

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/640/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/640/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2021, 3:13 PM
Harbormaster failed remote builds in B20353: Diff 19284!
swh-public-ci added a comment.Mar 30 2021, 6:02 PM

Build is green

Patch application report for D5367 (id=19284)

Rebasing onto ffd9fbccbf...

Current branch diff-target is up to date.
Changes applied before test
commit 3a9fbc15d8f8d09089e41e1baf12ab1d526cb20d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Mar 25 19:04:28 2021 +0100

    auth: Use generic Django authentication backends from swh-auth
    
    Django authentication backends and middleware based on the use of
    Keycloak and OpenID Connect have been moved to the swh-auth module
    and  turned into generic ones in order to easily reuse them in any
    Django application.
    
    So remove all code and tests that have been moved in swh-auth and
    configure swh-web to use the generic authentication backends and
    middleware.
    
    Closes T3150

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/641/ for more details.

Harbormaster completed remote builds in B20353: Diff 19284.Mar 30 2021, 6:02 PM
anlambert requested review of this revision.Mar 30 2021, 6:02 PM
ardumont accepted this revision.Mar 30 2021, 6:07 PM
ardumont added a subscriber: ardumont.

lgtm

requirements.txt
24

no bump in requirements-swh.txt about swh.auth >= 0.5 ?

swh/web/tests/conftest.py
29

don't you have a warning about this?

I remembered that at some point, they removed the possibility of defining this here...

This revision is now accepted and ready to land.Mar 30 2021, 6:07 PM
anlambert added inline comments.Mar 30 2021, 6:53 PM
requirements.txt
24

right

swh/web/tests/conftest.py
29

Nope, because test*/conftest.py file can contain pytest_plugins variable (see doc)

anlambert updated this revision to Diff 19302.Mar 30 2021, 6:54 PM

Bump swh-auth[django] requirement.

swh-public-ci added a comment.Mar 30 2021, 7:01 PM

Build is green

Patch application report for D5367 (id=19302)

Rebasing onto ffd9fbccbf...

Current branch diff-target is up to date.
Changes applied before test
commit a42327ff4fd57e93d880fb1c71018efa139bcf72
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Mar 25 19:04:28 2021 +0100

    auth: Use generic Django authentication backends from swh-auth
    
    Django authentication backends and middleware based on the use of
    Keycloak and OpenID Connect have been moved to the swh-auth module
    and  turned into generic ones in order to easily reuse them in any
    Django application.
    
    So remove all code and tests that have been moved in swh-auth and
    configure swh-web to use the generic authentication backends and
    middleware.
    
    Closes T3150

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/642/ for more details.

Harbormaster completed remote builds in B20370: Diff 19302.Mar 30 2021, 7:01 PM
Closed by commit rDWAPPSa42327ff4fd5: auth: Use generic Django authentication backends from swh-auth (authored by anlambert). · Explain WhyMar 30 2021, 7:18 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSa42327ff4fd5: auth: Use generic Django authentication backends from swh-auth.

Revision Contents
Changeset List

PathSize
2 lines
1 line
swh/
web/
auth/
58 lines
132 lines
settings/
12 lines
templates/
2 lines
tests/
api/
views/
32 lines
auth/
31 lines
259 lines
28 lines

Diff 19303

View Options

requirements-swh.txt

Loading...
View Options

requirements.txt

Loading...
View Options

swh/web/auth/backends.py

Loading...
View Options

swh/web/auth/middlewares.py

Loading...
View Options

swh/web/auth/utils.py

Loading...
View Options

swh/web/auth/views.py

Loading...
View Options

swh/web/settings/common.py

Loading...
View Options

swh/web/templates/layout.html

Loading...
View Options

swh/web/tests/api/views/test_graph.py

Loading...
View Options

swh/web/tests/auth/test_api_auth.py

Loading...
View Options

swh/web/tests/auth/test_backends.py

Loading...
View Options

swh/web/tests/auth/test_middlewares.py

Loading...
View Options

swh/web/tests/auth/test_utils.py

Loading...
View Options

swh/web/tests/auth/test_views.py

Loading...
View Options

swh/web/tests/conftest.py

Loading...
About · Developer information · Legal