Page MenuHomeSoftware Heritage
Differential D5362

origin_visit_status_add: Fix inconsistent/incorrect errors when type is None and visit is missing.
ClosedPublic
Actions

Authored by vlorentz on Mar 26 2021, 3:30 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOac6f642372dd: origin_visit_status_add: Fix inconsistent/incorrect errors when type is None…

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 26 2021, 3:30 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 26 2021, 3:30 PM
swh-public-ci added a comment.Mar 26 2021, 3:36 PM

Build is green

Patch application report for D5362 (id=19211)

Rebasing onto eff2383717...

Current branch diff-target is up to date.
Changes applied before test
commit ac6f642372dd30acaf723447f202f78344255d0c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 26 15:17:12 2021 +0100

    origin_visit_status_add: Fix inconsistent/incorrect errors when type is None and visit is missing.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1235/ for more details.

Harbormaster completed remote builds in B20292: Diff 19211.Mar 26 2021, 3:36 PM
vlorentz requested review of this revision.Mar 26 2021, 3:36 PM
ardumont accepted this revision.Mar 29 2021, 9:08 AM
ardumont added a subscriber: ardumont.

lgtm

This revision is now accepted and ready to land.Mar 29 2021, 9:08 AM
Closed by commit rDSTOac6f642372dd: origin_visit_status_add: Fix inconsistent/incorrect errors when type is None… (authored by vlorentz). · Explain WhyMar 29 2021, 10:22 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTOac6f642372dd: origin_visit_status_add: Fix inconsistent/incorrect errors when type is None….

Revision Contents
Changeset List

PathSize
swh/
storage/
cassandra/
11 lines
postgresql/
6 lines
tests/
27 lines

Diff 19239

View Options

swh/storage/cassandra/storage.py

Loading...
View Options

swh/storage/postgresql/storage.py

Loading...
View Options

swh/storage/tests/storage_tests.py

Loading...
About · Developer information · Legal