Differential D5318

django/utils: Add KeycloakOpenIDConnect factory function
ClosedPublic
Actions

Authored by anlambert on Mar 24 2021, 3:40 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDAUTH3e12aae1b486: django/utils: Add KeycloakOpenIDConnect factory function

Summary

Add keycloak_oidc_client factory to instantiate KeycloakOpenIDConnect
class from the following django settings:

KEYCLOAK_SERVER_URL
KEYCLOAK_REALM_NAME
KEYCLOAK_CLIENT_ID

This is required before moving the generic django OIDC auth backends
from swh-web to swh-auth.

Diff Detail

Repository

rDAUTH Common authentication libraries

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 24 2021, 3:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 24 2021, 3:40 PM

Build has FAILED

Patch application report for D5318 (id=19077)

Rebasing onto 7ff9562451...

Current branch diff-target is up to date.

Changes applied before test

commit 9fb7ea0b481a04dd3d2c1b0a205a89a07f965db1
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Mar 24 15:28:53 2021 +0100

    django/utils: Add KeycloakOpenIDConnect factory function
    
    Add keycloak_oidc_client factory to instantiate KeycloakOpenIDConnect
    class from the following django settings:
    
      - KEYCLOAK_SERVER_URL
      - KEYCLOAK_REALM_NAME
      - KEYCLOAK_CLIENT_ID
    
    This is required before moving the generic django OIDC auth backends
    from swh-web to swh-auth.

Link to build: https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/46/
See console output for more information: https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/46/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 24 2021, 3:41 PM

Harbormaster failed remote builds in B20168: Diff 19077!

Add missing pytest-mock requirement

Build is green

Patch application report for D5318 (id=19078)

Rebasing onto 7ff9562451...

Current branch diff-target is up to date.

Changes applied before test

commit 3e12aae1b486f77831854efa1a72f92416b0176b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Mar 24 15:28:53 2021 +0100

    django/utils: Add KeycloakOpenIDConnect factory function
    
    Add keycloak_oidc_client factory to instantiate KeycloakOpenIDConnect
    class from the following django settings:
    
      - KEYCLOAK_SERVER_URL
      - KEYCLOAK_REALM_NAME
      - KEYCLOAK_CLIENT_ID
    
    This is required before moving the generic django OIDC auth backends
    from swh-web to swh-auth.

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/47/ for more details.

Harbormaster completed remote builds in B20169: Diff 19078.Mar 24 2021, 3:43 PM

anlambert requested review of this revision.Mar 24 2021, 3:43 PM

ardumont accepted this revision.Mar 24 2021, 4:09 PM

This revision is now accepted and ready to land.Mar 24 2021, 4:09 PM

Closed by commit rDAUTH3e12aae1b486: django/utils: Add KeycloakOpenIDConnect factory function (authored by anlambert). · Explain WhyMar 24 2021, 4:59 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDAUTH3e12aae1b486: django/utils: Add KeycloakOpenIDConnect factory function.