Differential D5309

django/models: Ensure OIDCUser model will not be created in database
ClosedPublic
Actions

Authored by anlambert on Mar 23 2021, 3:36 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3150: Move generic django authentication code to swh-auth

Commits

rDAUTHd7ecd21e2fa5: django/models: Ensure OIDCUser model will not be created in database

Summary

OIDCUser model will not be persisted to django database as those
information are already stored in the identity provider one.

So ensure no table for the model will be created in django database
by setting the auto_created meta flag to True.

Related to T3150

Diff Detail

Repository

rDAUTH Common authentication libraries

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 23 2021, 3:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 23 2021, 3:36 PM

Build is green

Patch application report for D5309 (id=19040)

Rebasing onto 45ec395cce...

Current branch diff-target is up to date.

Changes applied before test

commit d7ecd21e2fa5f9d8b38823c0ba0de1e021f1b587
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 23 14:25:55 2021 +0100

    django/models: Ensure OIDCUser model will not be created in database
    
    OIDCUser model will not be persisted to django database as those
    information are already stored in the identity provider one.
    
    So ensure no table for the model will be created in django database
    by setting the auto_created meta flag to True.
    
    Related to T3150

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/39/ for more details.

Harbormaster completed remote builds in B20116: Diff 19040.Mar 23 2021, 3:37 PM

anlambert requested review of this revision.Mar 23 2021, 3:37 PM

anlambert added a child revision: D5310: auth: Use OIDCUser model directly instead of inheriting from it.Mar 23 2021, 3:41 PM

ardumont accepted this revision.Mar 23 2021, 3:43 PM

This revision is now accepted and ready to land.Mar 23 2021, 3:43 PM

Closed by commit rDAUTHd7ecd21e2fa5: django/models: Ensure OIDCUser model will not be created in database (authored by anlambert). · Explain WhyMar 23 2021, 3:49 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDAUTHd7ecd21e2fa5: django/models: Ensure OIDCUser model will not be created in database.