Differential D5304

auth.pytest_plugin: Adjust error type according to reality
ClosedPublic
Actions

Authored by ardumont on Mar 23 2021, 10:49 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2858: Use keycloak authentication for the deposit

Commits

rDAUTH45ec395cce8f: auth.pytest_plugin: Adjust error type according to reality

Summary

Prior to this commit, this raised a basic error message instead of a json dict bytes
encoded [1]

This commit fixes it.

The reality of tests trying to fix the deposit authentication handling which is awkward
for now.

Related to T2858
Related to D5302

[1] Related to P981

Test Plan

tox

Diff Detail

Repository

rDAUTH Common authentication libraries

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20079
Build 31175: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31174: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 23 2021, 10:49 AM

Build is green

Patch application report for D5304 (id=19002)

Rebasing onto e1bc4f10a3...

Current branch diff-target is up to date.

Changes applied before test

commit 45ec395cce8f9f0b586c95d1b1d95aac83277263
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 23 10:44:43 2021 +0100

    auth.pytest_plugin: Adjust error type according to reality
    
    Prior to this commit, this raised a basic error message instead of a json dict bytes
    encoded.
    
    This commit fixes it.
    
    Related to T2858

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/38/ for more details.

Harbormaster completed remote builds in B20079: Diff 19002.Mar 23 2021, 10:50 AM

ardumont requested review of this revision.Mar 23 2021, 10:50 AM

ardumont mentioned this in D5302: deposit.auth: Adjust authentication error message.Mar 23 2021, 10:59 AM

anlambert accepted this revision.Mar 23 2021, 11:12 AM

This revision is now accepted and ready to land.Mar 23 2021, 11:12 AM

Closed by commit rDAUTH45ec395cce8f: auth.pytest_plugin: Adjust error type according to reality (authored by ardumont). · Explain WhyMar 23 2021, 11:14 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDAUTH45ec395cce8f: auth.pytest_plugin: Adjust error type according to reality.