auth: Use OIDCUser model from swh-auth
ClosedPublic
Actions

Authored by anlambert on Mar 22 2021, 5:05 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3150: Move generic django authentication code to swh-auth

Commits

rDWAPPS65c0037d9020: auth: Use OIDCUser model from swh-auth

Summary

The OIDCUser model has been integrated in swh-auth module so
inherit from it instead of having code duplication.

Related to T3150

Diff Detail

Repository

rDWAPPS Web applications

Branch

use-swh-auth-user-model

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20060
Build 31139: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31138: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 22 2021, 5:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 22 2021, 5:05 PM

Build is green

Patch application report for D5299 (id=18982)

Rebasing onto cc652d5240...

Current branch diff-target is up to date.

Changes applied before test

commit 65c0037d902060046358436e3bdb4680741776a4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Mar 22 16:56:29 2021 +0100

    auth: Use OIDCUser model from swh-auth
    
    The OIDCUser model has been integrated in swh-auth module so
    inherit from it instead of having code duplication.
    
    Related to T3150

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/631/ for more details.

Harbormaster completed remote builds in B20060: Diff 18982.Mar 22 2021, 5:12 PM

anlambert requested review of this revision.Mar 22 2021, 5:12 PM

\o/

This revision is now accepted and ready to land.Mar 22 2021, 5:41 PM

anlambert added inline comments.Mar 22 2021, 6:05 PM

swh/web/auth/migrations/0003_delete_oidcuser.py
13	For the record, that model is deleted from database because previously I did not use the `auto_created` flag in the `OIDCUser` meta info. As the model is never persisted to database, the table can be safely removed,