Fix/update docstrings of build_swh_revision.
ClosedPublic
Actions

Authored by vlorentz on Mar 16 2021, 11:54 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLDSVNe66eea6d3daa: Fix/update docstrings of build_swh_revision.

Summary

They were wrong/misleading:

'rev' is an int, not a dict
'commit' is the data, not metadata in the SWH sense

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 16 2021, 11:54 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 16 2021, 11:54 AM

Build is green

Patch application report for D5255 (id=18839)

Rebasing onto fc530fb14f...

Current branch diff-target is up to date.

Changes applied before test

commit a129049d5314db553ddce4489c218db17c574960
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 16 11:54:23 2021 +0100

    Fix/update docstrings of build_swh_revision.
    
    They were wrong/misleading:
    
    * 'rev' is an int, not a dict
    * 'commit' is the data, not metadata in the SWH sense

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/124/ for more details.

Harbormaster completed remote builds in B19933: Diff 18839.Mar 16 2021, 11:56 AM

vlorentz requested review of this revision.Mar 16 2021, 11:56 AM

forgot to stage a change

Build is green

Patch application report for D5255 (id=18840)

Rebasing onto fc530fb14f...

Current branch diff-target is up to date.

Changes applied before test

commit e66eea6d3daa05b9824fd0df1f7e2042083b7653
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 16 11:54:23 2021 +0100

    Fix/update docstrings of build_swh_revision.
    
    They were wrong/misleading:
    
    * 'rev' is an int, not a dict
    * 'commit' is the data, not metadata in the SWH sense

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/125/ for more details.

Harbormaster completed remote builds in B19934: Diff 18840.Mar 16 2021, 11:59 AM

anlambert accepted this revision.Mar 16 2021, 12:02 PM

anlambert added a subscriber: anlambert.

anlambert added inline comments.