Differential D5230

swh.auth.pytest_plugin: Make decoded_token consistent with user_info
ClosedPublic
Actions

Authored by ardumont on Mar 11 2021, 3:55 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2858: Use keycloak authentication for the deposit

Commits

rDAUTHacf199d61c53: swh.auth.pytest_plugin: Make decoded_token consistent with user_info

Summary

Tester will want to craft carefully the keycloak mock so it returns
consistent data.

Currently the decoded_token and user_info are hard-coded to consistent values. So using
the default keycloak mock is ok. As soon as other testers will want another user_info,
the decoded token will diverge and not return the correct user_info subpart of the
decoded token.

This commits fixes such behavior and allows the decoded token to stay consistent with
the user_info.

Related to T2858

Diff Detail

Repository

rDAUTH Common authentication libraries

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 11 2021, 3:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 11 2021, 3:55 PM

Build is green

Patch application report for D5230 (id=18751)

Rebasing onto 68e9d921b1...

Current branch diff-target is up to date.

Changes applied before test

commit a05ecce635d7a34657dc81b4f2f4a162b036f702
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 11 15:53:12 2021 +0100

    swh.auth.pytest_plugin: Make decoded_token consistent with user_info
    
    Related to T2858

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/27/ for more details.

Harbormaster completed remote builds in B19847: Diff 18751.Mar 11 2021, 3:56 PM

ardumont requested review of this revision.Mar 11 2021, 3:56 PM

ardumont edited the summary of this revision. (Show Details)Mar 11 2021, 3:59 PM