Page MenuHomeSoftware Heritage

Actually store SWHIDs in variables named 'swhid'
ClosedPublic

Authored by vlorentz on Mar 5 2021, 5:02 PM.

Details

Summary

And remove variables named 'uri' that actually contained SWHIDs.

Diff Detail

Repository
rDLDHG Mercurial loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19747
Build 30654: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30653: arc lint + arc unit

Event Timeline

vlorentz retitled this revision from Actually store SWHIDs in variable named 'swhid' to Actually store SWHIDs in variables named 'swhid'.Mar 5 2021, 5:03 PM

Build is green

Patch application report for D5207 (id=18652)

Could not rebase; Attempt merge onto 1b4780030e...

Updating 1b47800..745188a
Fast-forward
 swh/loader/mercurial/identify.py | 74 +++++++++++++++++++++-------------------
 1 file changed, 38 insertions(+), 36 deletions(-)
Changes applied before test
commit 745188a16a71d9e67f953af7752dd98df09aa908
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 5 17:02:33 2021 +0100

    Actually store SWHIDs in variable named 'swhid'
    
    And remove variables named 'uri' that actually contained SWHIDs.

commit c1808d132f19624996782dc8643459d9325d5e5e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 5 16:28:23 2021 +0100

    Use CoreSWHID instead of the deprecated/removed SWHID class
    
    Required to silence warnings with swh-model 1.0.0,
    and error with swh-model >= 1.0.1

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/184/ for more details.

Build is green

Patch application report for D5207 (id=18653)

Rebasing onto 1b4780030e...

Current branch diff-target is up to date.
Changes applied before test
commit a62318d7256b7317cd063a616189be6518c19f34
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 5 17:02:33 2021 +0100

    Actually store SWHIDs in variables named 'swhid'
    
    And remove variables named 'uri' that actually contained SWHIDs.

commit c1808d132f19624996782dc8643459d9325d5e5e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 5 16:28:23 2021 +0100

    Use CoreSWHID instead of the deprecated/removed SWHID class
    
    Required to silence warnings with swh-model 1.0.0,
    and error with swh-model >= 1.0.1

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/185/ for more details.

Build is green

Patch application report for D5207 (id=18654)

Could not rebase; Attempt merge onto 1b4780030e...

Updating 1b47800..a62318d
Fast-forward
 swh/loader/mercurial/identify.py | 74 +++++++++++++++++++++-------------------
 1 file changed, 38 insertions(+), 36 deletions(-)
Changes applied before test
commit a62318d7256b7317cd063a616189be6518c19f34
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 5 17:02:33 2021 +0100

    Actually store SWHIDs in variables named 'swhid'
    
    And remove variables named 'uri' that actually contained SWHIDs.

commit c1808d132f19624996782dc8643459d9325d5e5e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 5 16:28:23 2021 +0100

    Use CoreSWHID instead of the deprecated/removed SWHID class
    
    Required to silence warnings with swh-model 1.0.0,
    and error with swh-model >= 1.0.1

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/186/ for more details.

anlambert added a subscriber: anlambert.

Looks good to me.

This revision is now accepted and ready to land.Mar 5 2021, 5:14 PM