Differential D5193

Ensure the elasticsearch indexes are initialized before the first request
ClosedPublic
Actions

Authored by vsellier on Mar 3 2021, 6:03 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3076: [swh-search] Improve the index/mapping migration process

Commits

rDSEA9e0db2bd4fd0: Ensure the elasticsearch indexes are initialized before the first request

Summary

Use a flask hook to be sure the index is initialized before

performing any action

Fix the server tests to avoid a side effect with the global

application configuration not reset between 2 tests

Related to T3076

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.Mar 3 2021, 6:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 3 2021, 6:03 PM

Build is green

Patch application report for D5193 (id=18571)

Rebasing onto 7c795a603f...

Current branch diff-target is up to date.

Changes applied before test

commit f5f9b861b748f38d987cf3f493e9dccc79d5f072
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Mar 2 10:30:16 2021 +0100

    Ensure the elasticsearch indexes are initialized before the first request
    
    - Use a flask hook to be sure the index is initialiazed before
    performing any action
    - Fix the server tests to avoid a side effect with the global
    application configuration not reset between 2 tests
    
    Related to T3076

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/101/ for more details.

Harbormaster completed remote builds in B19661: Diff 18571.Mar 3 2021, 6:05 PM

vsellier requested review of this revision.Mar 3 2021, 6:05 PM

fix wrong error log level
fix typo on the commit message

vsellier edited the summary of this revision. (Show Details)Mar 3 2021, 6:10 PM

Build is green

Patch application report for D5193 (id=18572)

Rebasing onto 7c795a603f...

Current branch diff-target is up to date.

Changes applied before test

commit 9e0db2bd4fd0713fd61ce6c391ce5190ba3207e3
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Mar 2 10:30:16 2021 +0100

    Ensure the elasticsearch indexes are initialized before the first request
    
    - Use a flask hook to be sure the index is initialized before
    performing any action
    - Fix the server tests to avoid a side effect with the global
    application configuration not reset between 2 tests
    
    Related to T3076

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/102/ for more details.

Harbormaster completed remote builds in B19662: Diff 18572.Mar 3 2021, 6:12 PM

ardumont accepted this revision.Mar 3 2021, 6:22 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.