Page MenuHomeSoftware Heritage
Differential D5188

Stop using deprecated constants from swh.model.identifiers
ClosedPublic
Actions

Authored by anlambert on Mar 3 2021, 9:55 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPSe0f629e75462: Stop using deprecated constants from swh.model.identifiers
Summary

Those should have been replaced since some time now as swh-web
was the latest component to use these swh.model.identifiers constants.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 3 2021, 9:55 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 3 2021, 9:55 AM
swh-public-ci added a comment.Mar 3 2021, 10:02 AM

Build has FAILED

Patch application report for D5188 (id=18546)

Rebasing onto 457f8f57c0...

Current branch diff-target is up to date.
Changes applied before test
commit 6f419ccba884b3279cd1e6e40f4510a8d87dd02b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Mar 3 09:55:29 2021 +0100

    [wip] stop using deprecated constants from swh.model.identifiers
    
    doesn't pass because I'm messing up the types in SWHObjectInfo

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/605/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/605/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 3 2021, 10:02 AM
Harbormaster failed remote builds in B19625: Diff 18546!
anlambert commandeered this revision.Sep 23 2021, 3:03 PM
anlambert added a reviewer: vlorentz.
anlambert updated this revision to Diff 23007.Sep 23 2021, 3:04 PM

Update:

  • Rebase
  • Fix remaining failing tests
anlambert retitled this revision from [wip] stop using deprecated constants from swh.model.identifiers to Stop using deprecated constants from swh.model.identifiers.Sep 23 2021, 3:05 PM
anlambert edited the summary of this revision. (Show Details)
anlambert edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Sep 23 2021, 3:21 PM

Build has FAILED

Patch application report for D5188 (id=23007)

Rebasing onto 6722da987b...

Current branch diff-target is up to date.
Changes applied before test
commit 47d01f71c3b14e1a39c39e1e958cabb93c05d26a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 23 11:43:39 2021 +0200

    Stop using deprecated constants from swh.model.identifiers
    
    Those should have been replaced since some time now as swh-web
    was the latest component to use these constants.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1117/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1117/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 23 2021, 3:21 PM
Harbormaster failed remote builds in B23933: Diff 23007!
anlambert updated this revision to Diff 23010.Sep 23 2021, 4:14 PM

Fix sphinx doc build and update years in license headers

swh-public-ci added a comment.Sep 23 2021, 4:29 PM

Build is green

Patch application report for D5188 (id=23010)

Rebasing onto 6722da987b...

Current branch diff-target is up to date.
Changes applied before test
commit b073d42b7652252e416eda84e3df3af862cb5e2e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 23 11:43:39 2021 +0200

    Stop using deprecated constants from swh.model.identifiers
    
    Those should have been replaced since some time now as swh-web
    was the latest component to use these constants.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1118/ for more details.

Harbormaster completed remote builds in B23936: Diff 23010.Sep 23 2021, 4:29 PM
anlambert requested review of this revision.Sep 23 2021, 4:29 PM
anlambert updated this revision to Diff 23015.Sep 23 2021, 5:08 PM

Remove debug print

vlorentz accepted this revision.Sep 23 2021, 5:17 PM

cool, thanks

This revision is now accepted and ready to land.Sep 23 2021, 5:17 PM
swh-public-ci added a comment.Sep 23 2021, 5:25 PM

Build is green

Patch application report for D5188 (id=23015)

Rebasing onto 6722da987b...

Current branch diff-target is up to date.
Changes applied before test
commit e0f629e75462ad2aedf8f4778c0b397db537dd79
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 23 11:43:39 2021 +0200

    Stop using deprecated constants from swh.model.identifiers
    
    Those should have been replaced since some time now as swh-web
    was the latest component to use these constants.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1119/ for more details.

Harbormaster completed remote builds in B23941: Diff 23015.Sep 23 2021, 5:25 PM
Closed by commit rDWAPPSe0f629e75462: Stop using deprecated constants from swh.model.identifiers (authored by vlorentz, committed by anlambert). · Explain WhySep 23 2021, 5:26 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSe0f629e75462: Stop using deprecated constants from swh.model.identifiers.

Revision Contents
Changeset List

PathSize
swh/
web/
api/
views/
8 lines
browse/
52 lines
views/
25 lines
17 lines
32 lines
25 lines
common/
43 lines
16 lines
69 lines
4 lines
3 lines
misc/
18 lines
22 lines
templates/
includes/
4 lines
26 lines
tests/
api/
10 lines
views/
55 lines
browse/
7 lines
views/
54 lines
44 lines
30 lines
22 lines
20 lines
18 lines
common/
62 lines
193 lines

Diff 23017

View Options

swh/web/api/views/identifiers.py

Loading...
View Options

swh/web/browse/snapshot_context.py

Loading...
View Options

swh/web/browse/views/content.py

Loading...
View Options

swh/web/browse/views/directory.py

Loading...
View Options

swh/web/browse/views/release.py

Loading...
View Options

swh/web/browse/views/revision.py

Loading...
View Options

swh/web/common/archive.py

Loading...
View Options

swh/web/common/converters.py

Loading...
View Options

swh/web/common/identifiers.py

Loading...
View Options

swh/web/common/swh_templatetags.py

Loading...
View Options

swh/web/common/typing.py

Loading...
View Options

swh/web/misc/badges.py

Loading...
View Options

swh/web/misc/iframe.py

Loading...
View Options

swh/web/templates/includes/show-metadata.html

Loading...
View Options

swh/web/templates/includes/show-swhids.html

Loading...
View Options

swh/web/tests/api/test_apiresponse.py

Loading...
View Options

swh/web/tests/api/views/test_identifiers.py

Loading...
View Options

swh/web/tests/browse/test_snapshot_context.py

Loading...
View Options

swh/web/tests/browse/views/test_content.py

Loading...
View Options

swh/web/tests/browse/views/test_directory.py

Loading...
View Options

swh/web/tests/browse/views/test_identifiers.py

Loading...
View Options

swh/web/tests/browse/views/test_origin.py

Loading...
View Options

swh/web/tests/browse/views/test_release.py

Loading...
View Options

swh/web/tests/browse/views/test_revision.py

Loading...
View Options

swh/web/tests/common/test_archive.py

Loading...
View Options

swh/web/tests/common/test_identifiers.py

Loading...
About · Developer information · Legal