Page MenuHomeSoftware Heritage

tests: Drop hypothesis < 6 requirement
ClosedPublic

Authored by anlambert on Mar 2 2021, 4:41 PM.

Details

Summary

Ensure tests can be executed using hypothesis >= 6 by suppressing
the function_scoped_fixture health check on tests that use a function
scope fixture in combination with @given.

Diff Detail

Repository
rDSTO Storage manager
Branch
hypothesis6-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19613
Build 30433: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30432: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 4:53 PM
Harbormaster failed remote builds in B19613: Diff 18534!

Build was aborted

Patch application report for D5183 (id=18534)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit 3744dc3a147556bc6380a8ed1867d7445cd53f8b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1164/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1164/console

Build has FAILED

Patch application report for D5183 (id=18534)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit 3744dc3a147556bc6380a8ed1867d7445cd53f8b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1165/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1165/console

Fix remaining failing tests

Build is green

Patch application report for D5183 (id=18535)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit 714e0ff39394f400d7e52145b382f2a25fec704c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1166/ for more details.

Fix mypy error when using hypothesis < 5.49 and improve commit message.

Build is green

Patch application report for D5183 (id=18551)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit 2aebc30d3fd64cacf4115234b60d6cecbd815e60
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given that does not need to be reset
    between individual hypothesis examples.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1168/ for more details.

Ensure mypy will be happy regardless hypothesis version

Build is green

Patch application report for D5183 (id=18557)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit f46244b57ec37beee2953c249716a268347408ba
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given that does not need to be reset
    between individual hypothesis examples.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1169/ for more details.

This revision is now accepted and ready to land.Mar 3 2021, 3:29 PM
This revision was automatically updated to reflect the committed changes.