Page MenuHomeSoftware Heritage
Differential D5183

tests: Drop hypothesis < 6 requirement
ClosedPublic
Actions

Authored by anlambert on Mar 2 2021, 4:41 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDSTOf46244b57ec3: tests: Drop hypothesis < 6 requirement
Summary

Ensure tests can be executed using hypothesis >= 6 by suppressing
the function_scoped_fixture health check on tests that use a function
scope fixture in combination with @given.

Diff Detail

Repository
rDSTO Storage manager
Branch
hypothesis6-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19613
Build 30433: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30432: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.algos.test_snapshot::test_snapshot_large
item = <Function test_snapshot_large> @pytest.hookimpl(hookwrapper=True)
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.algos.test_snapshot::test_snapshot_small
item = <Function test_snapshot_small> @pytest.hookimpl(hookwrapper=True)
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content
1 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin_visit
View Full Test Results (2 Failed · 750 Passed · 23 Skipped)

Event Timeline

anlambert created this revision.Mar 2 2021, 4:41 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 2 2021, 4:41 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2021, 4:53 PM
Harbormaster failed remote builds in B19613: Diff 18534!
swh-public-ci added a comment.Mar 2 2021, 4:54 PM

Build was aborted

Patch application report for D5183 (id=18534)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit 3744dc3a147556bc6380a8ed1867d7445cd53f8b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1164/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1164/console

swh-public-ci added a comment.Mar 2 2021, 4:59 PM

Build has FAILED

Patch application report for D5183 (id=18534)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit 3744dc3a147556bc6380a8ed1867d7445cd53f8b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1165/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1165/console

anlambert updated this revision to Diff 18535.Mar 2 2021, 5:08 PM

Fix remaining failing tests

swh-public-ci added a comment.Mar 2 2021, 5:14 PM

Build is green

Patch application report for D5183 (id=18535)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit 714e0ff39394f400d7e52145b382f2a25fec704c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1166/ for more details.

Harbormaster completed remote builds in B19614: Diff 18535.Mar 2 2021, 5:14 PM
anlambert requested review of this revision.Mar 2 2021, 5:14 PM
anlambert updated this revision to Diff 18551.Mar 3 2021, 11:09 AM

Fix mypy error when using hypothesis < 5.49 and improve commit message.

swh-public-ci added a comment.Mar 3 2021, 11:15 AM

Build is green

Patch application report for D5183 (id=18551)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit 2aebc30d3fd64cacf4115234b60d6cecbd815e60
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given that does not need to be reset
    between individual hypothesis examples.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1168/ for more details.

Harbormaster completed remote builds in B19630: Diff 18551.Mar 3 2021, 11:15 AM
anlambert updated this revision to Diff 18557.Mar 3 2021, 11:55 AM

Ensure mypy will be happy regardless hypothesis version

swh-public-ci added a comment.Mar 3 2021, 12:00 PM

Build is green

Patch application report for D5183 (id=18557)

Rebasing onto 14739c531f...

Current branch diff-target is up to date.
Changes applied before test
commit f46244b57ec37beee2953c249716a268347408ba
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 2 16:38:34 2021 +0100

    tests: Drop hypothesis < 6 requirement
    
    Ensure tests can be executed using hypothesis >= 6 by suppressing
    the function_scoped_fixture health check on tests that use a function
    scope fixture in combination with @given that does not need to be reset
    between individual hypothesis examples.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1169/ for more details.

Harbormaster completed remote builds in B19636: Diff 18557.Mar 3 2021, 12:00 PM
vlorentz accepted this revision.Mar 3 2021, 3:29 PM
This revision is now accepted and ready to land.Mar 3 2021, 3:29 PM
Closed by commit rDSTOf46244b57ec3: tests: Drop hypothesis < 6 requirement (authored by anlambert). · Explain WhyMar 3 2021, 3:38 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDSTOf46244b57ec3: tests: Drop hypothesis < 6 requirement.
anlambert mentioned this in T2969: Make tests compatible with hypothesis 6.Mar 11 2021, 11:08 AM

Revision Contents
Changeset List

PathSize
2 lines
swh/
storage/
tests/
18 lines

Diff 18534

View Options

requirements-test.txt

Loading...
View Options

swh/storage/tests/storage_tests.py

Loading...
About · Developer information · Legal