Differential D5149

Use ExtendedSWHID instead of SWHID.
ClosedPublic
Actions

Authored by vlorentz on Feb 25 2021, 4:30 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDGRPH8585eac20256: Use ExtendedSWHID instead of SWHID.

Summary

The SWHID class is deprecated, and no longer supports 'ori' objects.

Test Plan

Build will fail because it needs an unreleased version of swh-model

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 25 2021, 4:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 25 2021, 4:30 PM

Build has FAILED

Patch application report for D5149 (id=18411)

Rebasing onto 9f8c6de065...

Current branch diff-target is up to date.

Changes applied before test

commit 8585eac2025658ca661bbc1331a4f3d070540335
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 25 16:29:40 2021 +0100

    Use ExtendedSWHID instead of SWHID.
    
    The SWHID class is deprecated, and no longer supports 'ori' objects.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/67/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/67/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 25 2021, 4:30 PM

Harbormaster failed remote builds in B19489: Diff 18411!

vlorentz requested review of this revision.Feb 25 2021, 4:37 PM

lgtm

This revision is now accepted and ready to land.Feb 25 2021, 4:57 PM

Build has FAILED

Patch application report for D5149 (id=18411)

Rebasing onto 9f8c6de065...

Current branch diff-target is up to date.

Changes applied before test

commit 8585eac2025658ca661bbc1331a4f3d070540335
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 25 16:29:40 2021 +0100

    Use ExtendedSWHID instead of SWHID.
    
    The SWHID class is deprecated, and no longer supports 'ori' objects.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/68/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/68/console

Build is green

Patch application report for D5149 (id=18411)

Rebasing onto 9f8c6de065...

Current branch diff-target is up to date.

Changes applied before test

commit 8585eac2025658ca661bbc1331a4f3d070540335
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 25 16:29:40 2021 +0100

    Use ExtendedSWHID instead of SWHID.
    
    The SWHID class is deprecated, and no longer supports 'ori' objects.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/69/ for more details.

Harbormaster completed remote builds in B19489: Diff 18411.Feb 25 2021, 6:08 PM

Closed by commit rDGRPH8585eac20256: Use ExtendedSWHID instead of SWHID. (authored by vlorentz). · Explain WhyFeb 25 2021, 6:17 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDGRPH8585eac20256: Use ExtendedSWHID instead of SWHID..