Page MenuHomeSoftware Heritage

Fix SingleFileMapping case sensitivity
ClosedPublic

Authored by KShivendu on Feb 24 2021, 11:58 AM.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
codemeta-uppercase-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19552
Build 30337: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30336: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5136 (id=18368)

Rebasing onto 2be2c82267...

Current branch diff-target is up to date.
Changes applied before test
commit 244d4c992558284ce342b657ff6380765f0299c5
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Feb 24 16:23:20 2021 +0530

    Fix SingleFileMapping case sensitivity

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/147/ for more details.

This revision is now accepted and ready to land.Feb 24 2021, 12:16 PM
vlorentz added a subscriber: vlorentz.

Hi,

Thanks again for the diffs

Could you add a test case?

This revision now requires changes to proceed.Feb 25 2021, 9:50 AM

Could you add a test case?

I did not ask because i'm not sure it's so simple to add.
Let's see then ;)

Add testcase for CODEMETA.json

Build is green

Patch application report for D5136 (id=18388)

Could not rebase; Attempt merge onto 2be2c82267...

Updating 2be2c82..27d32cc
Fast-forward
 swh/indexer/metadata_dictionary/base.py |  2 +-
 swh/indexer/tests/test_metadata.py      | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 1 deletion(-)
Changes applied before test
commit 27d32cccbcfe8327b0f991b0ca5f620ee617f170
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Thu Feb 25 23:53:51 2021 +0530

    Add testcase to detect CODEMETA.json

commit 244d4c992558284ce342b657ff6380765f0299c5
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Feb 24 16:23:20 2021 +0530

    Fix SingleFileMapping case sensitivity

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/148/ for more details.

This revision is now accepted and ready to land.Feb 25 2021, 2:47 PM

Updating D5136: Fix SingleFileMapping case sensitivity

Build is green

Patch application report for D5136 (id=18475)

Could not rebase; Attempt merge onto 2be2c82267...

Updating 2be2c82..27d32cc
Fast-forward
 swh/indexer/metadata_dictionary/base.py |  2 +-
 swh/indexer/tests/test_metadata.py      | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 1 deletion(-)
Changes applied before test
commit 27d32cccbcfe8327b0f991b0ca5f620ee617f170
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Thu Feb 25 23:53:51 2021 +0530

    Add testcase to detect CODEMETA.json

commit 244d4c992558284ce342b657ff6380765f0299c5
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Feb 24 16:23:20 2021 +0530

    Fix SingleFileMapping case sensitivity

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/149/ for more details.

Updating D5136: Fix SingleFileMapping case sensitivity

Build is green

Patch application report for D5136 (id=18478)

Rebasing onto 2be2c82267...

Current branch diff-target is up to date.
Changes applied before test
commit 4045c04fb610fb1fa824a902de868b7298f0fc55
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Feb 24 16:23:20 2021 +0530

    Fix SingleFileMapping case sensitivity
    
    Add testcase to detect CODEMETA.json

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/150/ for more details.

This revision was automatically updated to reflect the committed changes.