Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3047: Enable to search in origin metadata with swh-search in webapp
- Commits
- rDWAPPS4be7279a7458: archive: Allow to search in origin metadata with swh-search backend
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build has FAILED
Patch application report for D5087 (id=18162)
Rebasing onto acb8fe8ed1...
Current branch diff-target is up to date.
Changes applied before test
commit 4be7279a74584213cbd50879357f4c391a57a135
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Tue Feb 16 18:28:58 2021 +0100
archive: Allow to search in origin metadata with swh-search backend
Conditionally allow to use swh-search backend in search_origin_metadata
function based on swh-web configuration:
- "search" configuration dict must be present and not empty
- "metadata_search_backend" field must be set to "swh-search"
Closes T3047Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/570/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/570/console
Build is green
Patch application report for D5087 (id=18162)
Rebasing onto acb8fe8ed1...
Current branch diff-target is up to date.
Changes applied before test
commit 4be7279a74584213cbd50879357f4c391a57a135
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Tue Feb 16 18:28:58 2021 +0100
archive: Allow to search in origin metadata with swh-search backend
Conditionally allow to use swh-search backend in search_origin_metadata
function based on swh-web configuration:
- "search" configuration dict must be present and not empty
- "metadata_search_backend" field must be set to "swh-search"
Closes T3047See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/571/ for more details.
lgtm
That will allow us to add the "swh-search" backend use for staging webapp for intrinsic-metadata search, thanks ;)
Indeed, it took me some time to implement it as I wanted to test the whole metadata chain in docker
(swh-loader -> swh-indexer-journal-client -> swh-indexer -> swh-search-journal-client-indexed -> swh-search)
in order to use real world data.
I will push a new swh-web tag once the diff landed.