Page MenuHomeSoftware Heritage

Simplify max_date()
ClosedPublic

Authored by olasd on Thu, Feb 11, 7:25 PM.

Details

Summary

The built-in max function can take an iterable directly, no need to
reimplement it.

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5066 (id=18079)

Rebasing onto cf32e37649...

Current branch diff-target is up to date.
Changes applied before test
commit cdb1775f247401ec24f8bb5dac7f9f2b40005bca
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Feb 9 10:33:19 2021 +0100

    Simplify max_date()
    
    The built-in `max` function can take an iterable directly, no need to
    reimplement it.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/301/ for more details.

olasd requested review of this revision.Thu, Feb 11, 7:27 PM
vsellier added a subscriber: vsellier.

👍nice! Thanks

This revision is now accepted and ready to land.Fri, Feb 12, 10:18 AM

lol \m/

("pq faire simple...")
I absolutely missed that when i initially saw that diff ;)

This revision was automatically updated to reflect the committed changes.