Page MenuHomeSoftware Heritage

nixguix: Ensure interaction with the origin url for edge case tests
ClosedPublic

Authored by ardumont on Thu, Feb 11, 10:54 AM.

Details

Summary

This also adds comment to clarify the test mechanism for said scenarios.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5062 (id=18047)

Rebasing onto 945ff242b5...

Current branch diff-target is up to date.
Changes applied before test
commit 79fca80d22fb262df39912128f7c1ea4bbcc8ea6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 11 10:52:44 2021 +0100

    nixguix: Ensure interaction with the origin url for edge case tests
    
    This also adds comment to clarify the test mechanism for said scenarios.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/368/ for more details.

why if m.url.startswith? Shouldn't the test know exhaustively which URLs the loader queries?

swh/loader/package/nixguix/tests/test_nixguix.py
132

why this conditional?

132

(disregard this, I wrote it in the "full" comment)

why if m.url.startswith? Shouldn't the test know exhaustively which URLs the loader queries?

because the loader does stuff with url with trailing / or not i think.

In any case, i'm rewroting it a bit according to suggestion here and in irc.

Build is green

Patch application report for D5062 (id=18048)

Rebasing onto 945ff242b5...

Current branch diff-target is up to date.
Changes applied before test
commit be39028a6b384e6bd69835e25de66521d93f9edc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 11 10:52:44 2021 +0100

    nixguix: Ensure interaction with the origin url for edge case tests
    
    This also adds comment to clarify the test mechanism for said scenarios.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/369/ for more details.

This revision is now accepted and ready to land.Thu, Feb 11, 11:18 AM

Build is green

Patch application report for D5062 (id=18049)

Rebasing onto 945ff242b5...

Current branch diff-target is up to date.
Changes applied before test
commit 7ea69e2b7058b280fc79ca61b9e09567038e00d2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 11 10:52:44 2021 +0100

    nixguix: Ensure interaction with the origin url for edge case tests
    
    This also adds comment to clarify the test mechanism for said scenarios.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/370/ for more details.