Page MenuHomeSoftware Heritage

loader.svn: Mark visit status as not_found when relevant
ClosedPublic

Authored by ardumont on Tue, Feb 9, 11:58 AM.

Details

Summary

When failing to communicate with the svn server at initialization time, a visit status
ends up in "not_found" status.

Other failures to communicate ends up in a visit status marked as "failed".

Related to T3030

Test Plan

tox
(failing until swh.loader.core > 0.16 it released)

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D5046 (id=17993)

Could not rebase; Attempt merge onto 824880e7d7...

Updating 824880e..7dccd60
Fast-forward
 requirements-swh.txt                   |  2 +-
 swh/loader/git/loader.py               | 10 ++++++---
 swh/loader/git/tests/test_from_disk.py | 41 +++++++++++++++++++++++++++++++++-
 swh/loader/git/tests/test_loader.py    | 40 +++++++++++++++++++++++++++++----
 4 files changed, 84 insertions(+), 9 deletions(-)
Changes applied before test
commit 7dccd6062cf717ca8c76642d215968873c7fed70
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Feb 9 11:53:42 2021 +0100

    loader.git: Mark visit status as not_found when relevant
    
    Related to T3030

commit f65fde77a942476de8173bb70c7eef9717bbffb0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 19:07:04 2021 +0100

    loader.git: Explicit the failure test cases
    
    Related to T3030

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/76/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/76/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Feb 9, 11:59 AM
Harbormaster failed remote builds in B19114: Diff 17993!

Build is green

Patch application report for D5046 (id=18056)

Could not rebase; Attempt merge onto 220678c753...

Updating 220678c..3fd2dc5
Fast-forward
 requirements-swh.txt                |  2 +-
 swh/loader/svn/loader.py            | 15 +++++++++++----
 swh/loader/svn/tests/test_loader.py | 16 ++++++++++++++--
 3 files changed, 26 insertions(+), 7 deletions(-)
Changes applied before test
commit 3fd2dc5203ed9cfa4378f1c03ca089528c66bc03
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 17:14:26 2021 +0100

    svn.loader: Mark visit status as not_found when relevant
    
    When failing to communicate with the svn server, a visit status ends up in "not_found"
    status.
    
    Related to T3030

commit ddc18d08514725fe7fb59857c8181e2cdaa47e3e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 17:36:57 2021 +0100

    svn.loader: Mark visit status as failed
    
    With the latest swh.loader.core 0.17, a partial without without snapshot is failed.
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/108/ for more details.

vlorentz retitled this revision from loader.git: Mark visit status as not_found when relevant to loader.svn: Mark visit status as not_found when relevant.
vlorentz added a subscriber: vlorentz.

dupe of D5041

This revision now requires changes to proceed.Thu, Feb 11, 1:15 PM

dupe of D5041

indeed, i mixed the git and svn loader diffs...

That seems too generic. SubversionException has some attributes that can be used to check what caused the error.

Thanks, I'll check.

That seems too generic. SubversionException has some attributes that can be used to check what caused the error.

Thanks, I'll check.

I don't see anything specific though [1]

What did i miss?

[1] https://github.com/jelmer/subvertpy/blob/bc652e106bd2a1c571f464b5fd7042c2282e8101/subvertpy/__init__.py#L102-L108

Build is green

Patch application report for D5046 (id=18085)

Rebasing onto ddc18d0851...

Current branch diff-target is up to date.
Changes applied before test
commit 1da0b342e3437c983a3f8e778b45906c8710c24e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 17:14:26 2021 +0100

    svn.loader: Mark visit status as not_found when relevant
    
    When failing to communicate with the svn server at initialization time, a visit status
    ends up in "not_found" status.
    
    Other failures to communicate ends up in a visit status marked as "failed".
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/109/ for more details.

vlorentz added inline comments.
swh/loader/svn/tests/test_loader.py
76

"somehow"

This revision is now accepted and ready to land.Fri, Feb 12, 11:24 AM

Build is green

Patch application report for D5046 (id=18086)

Rebasing onto ddc18d0851...

Current branch diff-target is up to date.
Changes applied before test
commit 71e3b4478432429a730cb80687602a12a2030cc1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 17:14:26 2021 +0100

    svn.loader: Mark visit status as not_found when relevant
    
    When failing to communicate with the svn server at initialization time, a visit status
    ends up in "not_found" status.
    
    Other failures to communicate ends up in a visit status marked as "failed".
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/110/ for more details.