Page MenuHomeSoftware Heritage

loader.git: Explicit the failure test cases
ClosedPublic

Authored by ardumont on Feb 8 2021, 5:50 PM.

Details

Summary

With the new loader.core 0.17, failed or partial status changed slightly.
This adds the necessary tests to explicit those.

Related to T3030

Test Plan

tox
(failing until swh.loader.core > 0.16 release)

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D5040 (id=17980)

Rebasing onto 220678c753...

Current branch diff-target is up to date.
Changes applied before test
commit aa71a198881188d7e42ea82d9896fcb394e6d1d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 17:36:57 2021 +0100

    svn.loader: Mark visit status as failed
    
    Related to T3030

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/101/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/101/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2021, 5:51 PM
Harbormaster failed remote builds in B19101: Diff 17980!

Build is green

Patch application report for D5040 (id=17980)

Rebasing onto 220678c753...

Current branch diff-target is up to date.
Changes applied before test
commit aa71a198881188d7e42ea82d9896fcb394e6d1d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 17:36:57 2021 +0100

    svn.loader: Mark visit status as failed
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/103/ for more details.

Build is green

Patch application report for D5040 (id=18053)

Rebasing onto 220678c753...

Current branch diff-target is up to date.
Changes applied before test
commit ddc18d08514725fe7fb59857c8181e2cdaa47e3e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 17:36:57 2021 +0100

    svn.loader: Mark visit status as failed
    
    With the latest swh.loader.core 0.17, a partial without without snapshot is failed.
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/105/ for more details.

ardumont retitled this revision from svn.loader: Mark visit status as failed to loader.git: Explicit the failure test cases.Feb 11 2021, 2:17 PM
ardumont edited the summary of this revision. (Show Details)

Build is green

Patch application report for D5040 (id=18061)

Rebasing onto 824880e7d7...

Current branch diff-target is up to date.
Changes applied before test
commit 11074801b0bb928c62442d4dd74d514cbbdbd0bf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 8 19:07:04 2021 +0100

    loader.git: Explicit the failure test cases
    
    With the new loader.core 0.17, failed or partial status changed slightly.
    This adds the necessary tests to explicit those.
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/77/ for more details.

This revision is now accepted and ready to land.Feb 11 2021, 2:23 PM