Differential D5031

docs: Update listers execution instructions
ClosedPublic
Actions

Authored by anlambert on Feb 5 2021, 2:51 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLSe72c15e97a2e: docs: Update listers execution instructions

Summary

Remove outdated part about listers database and use swh CLI in
README for executing a lister instead of raw Python code.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 5 2021, 2:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 5 2021, 2:51 PM

Build is green

Patch application report for D5031 (id=17927)

Rebasing onto 1803b707e4...

Current branch diff-target is up to date.

Changes applied before test

commit e72c15e97a2e2f6269a9fe3019e118fee0321395
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Feb 5 12:35:37 2021 +0100

    docs: Update listers execution instructions
    
    Remove outdated part about listers database and use swh CLI in
    README for executing a lister instead of raw Python code.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/246/ for more details.

Harbormaster completed remote builds in B19046: Diff 17927.Feb 5 2021, 2:54 PM

anlambert requested review of this revision.Feb 5 2021, 2:54 PM

lgtm

docs/run_a_new_lister.rst
86	You may also want to propose something like: select * from listed_origins lo inner join listers l on lo.lister_id=l.id where l.name='cgit' and l.instance_name='eclipse' limit 10;

This revision is now accepted and ready to land.Feb 5 2021, 2:58 PM

anlambert added inline comments.Feb 5 2021, 3:48 PM

docs/run_a_new_lister.rst
86	I will keep a simple query here, the idea is just to indicate in which database and table the data can be found.

ardumont added inline comments.Feb 5 2021, 3:49 PM

docs/run_a_new_lister.rst
86	yes, i guessed as much ;) why the "may". In my staging deployments (more than 1 lister), that query was too simple and returned too much. But granted within docker, there might be way less origins.