Differential D5028

journal_client: Deal with failed status message
ClosedPublic
Actions

Authored by ardumont on Feb 5 2021, 2:32 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3030: Improve loaders to deal with new visit status events

Commits

rDSCHaa507ac51c3f: journal_client: Deal with failed status message

Summary

As loader will start to create failed status message, deal with them if any.

Related to T3030

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 5 2021, 2:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 5 2021, 2:32 PM

ardumont mentioned this in D5024: package: Mark visit status as failed when relevant.Feb 5 2021, 2:33 PM

Build is green

Patch application report for D5028 (id=17920)

Rebasing onto 14feab9523...

Current branch diff-target is up to date.

Changes applied before test

commit 560344f0c8ebe4afd6cccfe50adcfe689227d4be
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 5 14:31:26 2021 +0100

    journal_client: Deal with failed status message
    
    As loader will start to create failed status message, deal with them if any.
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/297/ for more details.

Harbormaster completed remote builds in B19040: Diff 17920.Feb 5 2021, 2:34 PM

ardumont requested review of this revision.Feb 5 2021, 2:34 PM

ardumont edited the summary of this revision. (Show Details)Feb 5 2021, 2:38 PM

Add test

ardumont edited the summary of this revision. (Show Details)Feb 5 2021, 3:06 PM

Build is green

Patch application report for D5028 (id=17929)

Rebasing onto 14feab9523...

Current branch diff-target is up to date.

Changes applied before test

commit aa507ac51c3fd2547a60b1198cfdfd6206ee2ea8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 5 14:31:26 2021 +0100

    journal_client: Deal with failed status message
    
    As loader will start to create failed status message, deal with them if any.
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/298/ for more details.

Harbormaster completed remote builds in B19048: Diff 17929.Feb 5 2021, 3:09 PM

vlorentz accepted this revision.Feb 9 2021, 9:56 AM

This revision is now accepted and ready to land.Feb 9 2021, 9:56 AM

Closed by commit rDSCHaa507ac51c3f: journal_client: Deal with failed status message (authored by ardumont). · Explain WhyFeb 9 2021, 5:38 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCHaa507ac51c3f: journal_client: Deal with failed status message.