Page MenuHomeSoftware Heritage

loader: Make loader write the origin_visit_status' type
ClosedPublic

Authored by ardumont on Feb 5 2021, 11:44 AM.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5023 (id=17912)

Rebasing onto b332f4acd1...

Current branch diff-target is up to date.
Changes applied before test
commit 265d3b2b2ac6047cee40e26b145be500a9749a41
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 5 11:41:41 2021 +0100

    loader: Make loader write the origin_visit_status' type
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/342/ for more details.

vlorentz requested changes to this revision.Feb 5 2021, 2:07 PM
vlorentz added a subscriber: vlorentz.

I assumed that's because swh-storage currently fills in the gap, but we want to remove that behavior?

Could you explain this in the commit msg?

This revision now requires changes to proceed.Feb 5 2021, 2:07 PM

I assumed that's because swh-storage currently fills in the gap, but we want to remove that behavior?

exactly

Could you explain this in the commit msg?

yes

Update commit message to explicit we want to replace the storage's current behavior

This revision is now accepted and ready to land.Feb 5 2021, 2:14 PM

Build is green

Patch application report for D5023 (id=17917)

Rebasing onto b332f4acd1...

Current branch diff-target is up to date.
Changes applied before test
commit 65a513578d6c63bc99e0da9e17c6505ab82b8881
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 5 11:41:41 2021 +0100

    loader: Make loader write the origin_visit_status' type
    
    Currently the latest storage (> 0.21) does it. We want to move away from that behavior
    and let the loaders explicitly set it.
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/345/ for more details.