Differential D5012

postgresql: Fix dbversion() to return the max version instead of a random one.
ClosedPublic
Actions

Authored by vlorentz on Feb 4 2021, 2:30 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTOb0383833fe24: postgresql: Fix dbversion() to return the max version instead of a random one.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19002
Build 29443: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29442: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 4 2021, 2:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 4 2021, 2:30 PM

Build is green

Patch application report for D5012 (id=17883)

Could not rebase; Attempt merge onto 9a9f234e0a...

Updating 9a9f234e..e9441fef
Fast-forward
 swh/storage/cassandra/common.py     |  5 ----
 swh/storage/cassandra/converters.py |  2 +-
 swh/storage/cassandra/cql.py        |  3 +-
 swh/storage/cassandra/storage.py    |  3 +-
 swh/storage/postgresql/db.py        |  9 +++++-
 swh/storage/tests/storage_tests.py  | 59 +++++++++++++++++++++++++++----------
 swh/storage/utils.py                |  5 ++++
 7 files changed, 62 insertions(+), 24 deletions(-)

Changes applied before test

commit e9441fef13c11c3eb500403275ba7337ed0c77e1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 4 14:29:38 2021 +0100

    postgresql: Fix dbversion() to return the max version instead of a random one.

commit 508399ce2abf21f813acc9c56422cbbccca0ae3d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 4 13:59:09 2021 +0100

    storage_tests: recompute ids when evolving RawExtrinsicMetadata objects.
    
    For now this does nothing as RawExtrinsicMetadata has no 'id' field,
    but the equality assertions will become errors when the next version
    of swh.model is released.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1120/ for more details.

Harbormaster completed remote builds in B19002: Diff 17883.Feb 4 2021, 2:35 PM

vlorentz requested review of this revision.Feb 4 2021, 2:35 PM

ardumont accepted this revision.Feb 4 2021, 2:36 PM

This revision is now accepted and ready to land.Feb 4 2021, 2:36 PM

rebase

Build was aborted

Patch application report for D5012 (id=17958)

Rebasing onto efd8815b89...

Current branch diff-target is up to date.

Changes applied before test

commit b0383833fe240d9400f683d177ec3d5eef8ec1d6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 4 14:29:38 2021 +0100

    postgresql: Fix dbversion() to return the max version instead of a random one.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1141/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1141/console

Harbormaster failed remote builds in B19079: Diff 17958!Feb 8 2021, 12:33 PM

This revision was landed with ongoing or failed builds.Feb 8 2021, 12:35 PM

Closed by commit rDSTOb0383833fe24: postgresql: Fix dbversion() to return the max version instead of a random one. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTOb0383833fe24: postgresql: Fix dbversion() to return the max version instead of a random one..