Differential D4988

Adapt origin_get_latest_visit_status according to latest api change
ClosedPublic
Actions

Authored by ardumont on Feb 1 2021, 6:26 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS558990abd836: Adapt origin_get_latest_visit_status according to latest api change

Test Plan

tox
(failing until swh.storage > 0.21 [1], swh.loader.core > 0.15 [2], swh.loader.git > 0.5 [3] are released)

[1] D4976

[2] D4979

[3] D4999

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 1 2021, 6:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 1 2021, 6:26 PM

Build has FAILED

Patch application report for D4988 (id=17790)

Rebasing onto ab5401d73d...

Current branch diff-target is up to date.

Changes applied before test

commit 8dae9e71e55aaab1baf49ca90b63e04e31477a5d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 1 15:36:53 2021 +0100

    Adapt origin_get_latest_visit_status according to latest api change

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/562/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/562/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 1 2021, 6:28 PM

Harbormaster failed remote builds in B18931: Diff 17790!

ardumont mentioned this in D4976: storage: Make origin_get_latest_visit_status return OriginVisitStatus.Feb 2 2021, 8:35 AM

ardumont edited the summary of this revision. (Show Details)Feb 2 2021, 9:42 AM

Drop unneeded change (i think)

Build has FAILED

Patch application report for D4988 (id=17831)

Rebasing onto ab5401d73d...

Current branch diff-target is up to date.

Changes applied before test

commit 5f090d9b0bde305c849702c7b57bf832abddc1c5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Feb 2 16:06:02 2021 +0100

    Adapt origin_get_latest_visit_status according to latest api change

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/563/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/563/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 2 2021, 5:11 PM

Harbormaster failed remote builds in B18964: Diff 17831!

I'm missing a patch on the loader-git...

ardumont edited the summary of this revision. (Show Details)Feb 2 2021, 6:13 PM

ardumont edited the test plan for this revision. (Show Details)

ardumont edited the test plan for this revision. (Show Details)Feb 3 2021, 2:49 PM

Build is green

Patch application report for D4988 (id=17831)

Rebasing onto a985aaee63...

First, rewinding head to replay your work on top of it...
Applying: Adapt origin_get_latest_visit_status according to latest api change

Changes applied before test

commit c4c02ba422015e9263dd7068f5654fecd4392bfe
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Feb 2 16:06:02 2021 +0100

    Adapt origin_get_latest_visit_status according to latest api change

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/565/ for more details.

Harbormaster completed remote builds in B18964: Diff 17831.Feb 3 2021, 2:55 PM

ardumont requested review of this revision.Feb 3 2021, 2:55 PM

Rebase

Build is green

Patch application report for D4988 (id=17860)

Rebasing onto a985aaee63...

Current branch diff-target is up to date.

Changes applied before test

commit 558990abd836f8ef8b15d97ddffe743400f743d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Feb 2 16:06:02 2021 +0100

    Adapt origin_get_latest_visit_status according to latest api change

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/566/ for more details.

Harbormaster completed remote builds in B18982: Diff 17860.Feb 3 2021, 3:04 PM