Page MenuHomeSoftware Heritage

Change origin_visit_status_get_random interface to return visit_status
ClosedPublic

Authored by ardumont on Jan 29 2021, 6:24 PM.

Details

Summary

This returned a Tuple[OriginVisit, OriginVisitStatus].

This was required to have the missing information "type" for visit-status. This is no
longer needed as now OriginVisitStatus holds the type information.

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18903
Build 29288: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 29287: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4975 (id=17762)

Rebasing onto 76de53cb26...

First, rewinding head to replay your work on top of it...
Applying: Change origin_visit_status_get_random interface to return visit_status
Using index info to reconstruct a base tree...
M	swh/storage/postgresql/storage.py
Falling back to patching base and 3-way merge...
Auto-merging swh/storage/postgresql/storage.py
Changes applied before test
commit 9bb9c749d8e6135cffd4fec4bdac297fe17928b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jan 29 18:17:57 2021 +0100

    Change origin_visit_status_get_random interface to return visit_status
    
    This returned a Tuple[OriginVisit, OriginVisitStatus] which is no longer needed as now
    OriginVisitStatus held the type information now.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1113/ for more details.

This revision is now accepted and ready to land.Feb 2 2021, 10:53 AM
ardumont edited the summary of this revision. (Show Details)

Rebase

Build is green

Patch application report for D4975 (id=17851)

Rebasing onto f6ae8a062d...

Current branch diff-target is up to date.
Changes applied before test
commit 626b0bf8867b9ded52ac7524c17c972dc9214d70
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jan 29 18:17:57 2021 +0100

    Change origin_visit_status_get_random interface to return visit_status
    
    This returned a Tuple[OriginVisit, OriginVisitStatus] which is no longer needed as now
    OriginVisitStatus held the type information now.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1117/ for more details.