Page MenuHomeSoftware Heritage

Correctly return origin_visit_status.type value everywhere
ClosedPublic

Authored by vsellier on Jan 28 2021, 12:12 PM.

Details

Summary

If the type is not present on an origin_visit_status, it
should be computed from the origin_visit.
There was some methods which only return the origin_visit_status
value. It breaks the webapp mangling the type to empty value on
the search result page.

Related to T3001

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18839
Build 29181: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 29180: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4960 (id=17696)

Rebasing onto e433255dab...

Current branch diff-target is up to date.
Changes applied before test
commit 9529e43bc64301e117f95a97e6e08a29f57436c9
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Thu Jan 28 12:00:46 2021 +0100

    Correctly return origin_visit_status.type value everywhere
    
    If the type is not present on an origin_visit_status, it
    should be computed from the origin_visit.
    There was some methods which only return the origin_visit_status
    value. It breaks the webapp mangling the type to empty value on
    the search result page.
    
    Related to T3001

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1109/ for more details.

Build is green

Patch application report for D4960 (id=17698)

Rebasing onto e433255dab...

Current branch diff-target is up to date.
Changes applied before test
commit 76de53cb261fd54488904a20e7c50fcb0f3848ee
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Thu Jan 28 12:00:46 2021 +0100

    Correctly return origin_visit_status.type value everywhere
    
    If the type is not present on an origin_visit_status, it
    should be computed from the origin_visit.
    There were some methods which only return the origin_visit_status
    value. It breaks the webapp mangling the type to empty value on
    the search result page.
    
    Related to T3001

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1110/ for more details.

This revision is now accepted and ready to land.Jan 28 2021, 1:29 PM