Page MenuHomeSoftware Heritage

Remove tests' journal_data.py in favor of the version in swh-model
ClosedPublic

Authored by douardda on Jan 26 2021, 5:09 PM.

Details

Summary

prevent unnecessary coupling with swh-model.

Related to T2970.
Depends on D4950, still misses the dependency bump on swh-model (needs a tag).

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D4951 (id=17636)

Rebasing onto c451ecd542...

Current branch diff-target is up to date.
Changes applied before test
commit d91600aaee0a71c798446f8676a04e64773bdb25
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 19 10:21:41 2021 +0100

    Remove tests' journal_data.py in favor of the version in swh-model
    
    prevent unnecessary coupling with swh-model.
    
    Related to T2970.

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/141/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/141/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 26 2021, 5:09 PM
Harbormaster failed remote builds in B18774: Diff 17636!

bump dependency on swh-model 0.12

Build has FAILED

Patch application report for D4951 (id=17641)

Rebasing onto c451ecd542...

Current branch diff-target is up to date.
Changes applied before test
commit 70519211ed438cfbf7c3bf593f3d957d342e7708
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 19 10:21:41 2021 +0100

    Remove tests' journal_data.py in favor of the version in swh-model
    
    prevent unnecessary coupling with swh-model.
    
    Related to T2970.

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/142/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/142/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 26 2021, 5:27 PM
Harbormaster failed remote builds in B18779: Diff 17641!

Build is green

Patch application report for D4951 (id=17641)

Rebasing onto c451ecd542...

Current branch diff-target is up to date.
Changes applied before test
commit 70519211ed438cfbf7c3bf593f3d957d342e7708
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 19 10:21:41 2021 +0100

    Remove tests' journal_data.py in favor of the version in swh-model
    
    prevent unnecessary coupling with swh-model.
    
    Related to T2970.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/143/ for more details.

ardumont added a subscriber: ardumont.

for the sake of my questions

swh/journal/serializers.py
74

Is that in the scope?

95

please, remove ;)

swh/journal/tests/conftest.py
0

shouldn't this go in model as you did the other stuff?

This revision now requires changes to proceed.Jan 26 2021, 5:42 PM
swh/journal/serializers.py
95

But I have.. wait, wat? ah no I have not... (sorry)

swh/journal/tests/conftest.py
0

No but we should probably just use swh.model.hypothesis_strategies.object_dicts instead

swh/journal/tests/conftest.py
0

actually it's not used any more at all, so let's get rid of it

remove stuff added mistakenly, and properly deprecate journal_data instead of breaking swh-storage

Build is green

Patch application report for D4951 (id=17649)

Rebasing onto c451ecd542...

Current branch diff-target is up to date.
Changes applied before test
commit 2b9e9197c7da0bfb5741724a02a061c33d0cf4a2
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 19 10:21:41 2021 +0100

    Remove tests' journal_data.py in favor of the version in swh-model
    
    prevent unnecessary coupling with swh-model.
    
    Related to T2970.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/144/ for more details.

set the DeprecationWarning category in journal_data

Build is green

Patch application report for D4951 (id=17650)

Rebasing onto c451ecd542...

Current branch diff-target is up to date.
Changes applied before test
commit 9703864ef366904e719fafa2f6192cc5b0a1f07e
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jan 19 10:21:41 2021 +0100

    Remove tests' journal_data.py in favor of the version in swh-model
    
    prevent unnecessary coupling with swh-model.
    
    Related to T2970.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/145/ for more details.

lgtm

Thanks

swh/journal/tests/conftest.py
0

\m/

This revision is now accepted and ready to land.Jan 27 2021, 11:07 AM