Paths

Table of Contentst

Differential D4929

gitlab: Port to the new lister api
ClosedPublic
Actions

Authored by ardumont on Jan 23 2021, 4:00 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2987: Port gitlab lister to the new `swh.lister.pattern.Lister` API

Commits

rDLS1390a513f2e5: gitlab: Port to the new lister api

Summary

No evolution, plain portage.

Note:
The existing missing tests, eventual paper cuts, and authentication support will be addressed in subsequent diffs:

D4930: pagination test
D4932: incremental lister test
D4933: rate limit test
D4940: Support authentication

Related to T2987

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 18671
Build 28895: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28894: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 23 2021, 4:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 23 2021, 4:00 PM

Build is green

Patch application report for D4929 (id=17539)

Rebasing onto ff232f0d91...

Current branch diff-target is up to date.

Changes applied before test

commit 4611d7d75123ffd6ed2517a677f2000b53939887
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Jan 23 15:18:20 2021 +0100

    gitlab: Port to the new lister api

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/137/ for more details.

Harbormaster completed remote builds in B18671: Diff 17539.Jan 23 2021, 4:03 PM

ardumont requested review of this revision.Jan 23 2021, 4:03 PM

ardumont edited the summary of this revision. (Show Details)Jan 25 2021, 8:45 AM

ardumont added a task: T2987: Port gitlab lister to the new `swh.lister.pattern.Lister` API.

ardumont added a child revision: D4930: gitlab: Add tests on pagination.Jan 25 2021, 8:52 AM

ardumont edited the summary of this revision. (Show Details)Jan 25 2021, 8:55 AM

ardumont edited the summary of this revision. (Show Details)Jan 25 2021, 9:24 AM

ardumont edited the summary of this revision. (Show Details)

ardumont edited the summary of this revision. (Show Details)Jan 25 2021, 9:57 AM

anlambert accepted this revision.Jan 25 2021, 12:17 PM

anlambert added a subscriber: anlambert.

anlambert added inline comments.

swh/lister/gitlab/lister.py
81	Lister parameters should be documented, notably that the `url` parameter corresponds to the v4 api path of gitlab.
swh/lister/gitlab/tests/test_lister.py
22–47	This should be removed I guess.

This revision is now accepted and ready to land.Jan 25 2021, 12:17 PM

Closed by commit rDLS1390a513f2e5: gitlab: Port to the new lister api (authored by ardumont). · Explain WhyJan 25 2021, 12:54 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS1390a513f2e5: gitlab: Port to the new lister api.

ardumont marked an inline comment as done.Jan 25 2021, 1:17 PM

ardumont added inline comments.

swh/lister/gitlab/tests/test_lister.py
22–47	indeed and it's done in the next diffs which finally add those equivalent test. ( kept those here to avoid forgetting about adding those back).