This no longer checks the error message.
Fixes build [1]
[1] https://jenkins.softwareheritage.org/job/DDEP/job/tests/1273/console
Details
Details
Diff Detail
Diff Detail
- Repository
- rDDEP Push deposit
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D4870 (id=17261)
Rebasing onto 2c47667ab6...
Current branch diff-target is up to date.
Changes applied before test
commit 19e5a6dc21e89e39bc00b35fc74568414e9a8339
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jan 15 13:41:16 2021 +0100
test: Fix parse_swhid error message change failing test
Fixes build [1]
[1] https://jenkins.softwareheritage.org/job/DDEP/job/tests/1273/consoleSee https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/528/ for more details.
Comment Actions
Why do we still have tests that check error messages meant for human consumption, again? :-)
If the difference in how they fail is meaningful (which I don't know), they should raise different exceptions and we should just check their types.
The right fix here is stop checking those and just check that the raise failures or something.
Otherwise we will be here again, in the future, doing busy work maintaining tests that fail for entirely pointless reasons.
Comment Actions
Why do we still have tests that check error messages meant for human consumption, again? :-)
Probably because those were anterior to our discussion on this.
And right now, i was more concentrated on fixing the build and go run my
sprint than fixing properly this.
Ack, i'll try to simplify the checks.
Comment Actions
Build is green
Patch application report for D4870 (id=17274)
Rebasing onto 2c47667ab6...
Current branch diff-target is up to date.
Changes applied before test
commit 22c4e585ecc475e063283b848157ec2a625819bc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jan 15 13:41:16 2021 +0100
test: Fix failing test
This no longer checks the error messages.
Fixes build [1]
[1] https://jenkins.softwareheritage.org/job/DDEP/job/tests/1273/consoleSee https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/529/ for more details.