They were mixed in with snapshot tests.
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDMOD1d0c321275d2: test_identifiers: Reorder SWHID tests.
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 18281 Build 28223: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 28222: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D4840 (id=17137)
Could not rebase; Attempt merge onto 18fde50472...
Updating 18fde50..1d0c321 Fast-forward swh/model/tests/test_identifiers.py | 301 ++++++++++++++++++++---------------- 1 file changed, 164 insertions(+), 137 deletions(-)
Changes applied before test
commit 1d0c321275d27b6d194e3768990f4a983fbe6360
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jan 12 12:24:35 2021 +0100
test_identifiers: Reorder SWHID tests.
They were mixed in with snapshot tests.
commit 731d10d30695921685886364666f8b7f5b2a6c75
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jan 12 12:17:24 2021 +0100
test_identifiers: Make sure that {directory,revision,release,snapshot}_identifier() doesn't just return a value from the dict.
For example, before this commit, you could replace the code of
revision_identifier() with this:
def release_identifier(release):
return release.get("id", b"")
and all tests would still pass.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/196/ for more details.