Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDDEP795f27cb003e: tests: Deduplicate boilerplate when POSTing/PUTing an Atom document.
Diff Detail
Diff Detail
- Repository
- rDDEP Push deposit
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D4787 (id=16954)
Could not rebase; Attempt merge onto b85ca5f976...
Updating b85ca5f9..0f32502a Fast-forward swh/deposit/tests/api/test_collection.py | 326 +--------- .../tests/api/test_collection_add_to_origin.py | 158 +++++ swh/deposit/tests/api/test_collection_post_atom.py | 415 +++++++----- .../tests/api/test_collection_post_binary.py | 366 ++--------- .../tests/api/test_collection_post_metadata.py | 275 -------- .../tests/api/test_collection_reuse_slug.py | 242 +++++++ swh/deposit/tests/api/test_deposit_update.py | 717 +-------------------- swh/deposit/tests/api/test_deposit_update_atom.py | 608 +++++++++++++++++ .../tests/api/test_deposit_update_binary.py | 408 ++++++++++++ swh/deposit/tests/cli/test_client.py | 3 +- swh/deposit/tests/common.py | 31 + swh/deposit/tests/conftest.py | 25 +- 12 files changed, 1774 insertions(+), 1800 deletions(-) create mode 100644 swh/deposit/tests/api/test_collection_add_to_origin.py delete mode 100644 swh/deposit/tests/api/test_collection_post_metadata.py create mode 100644 swh/deposit/tests/api/test_collection_reuse_slug.py create mode 100644 swh/deposit/tests/api/test_deposit_update_atom.py create mode 100644 swh/deposit/tests/api/test_deposit_update_binary.py
Changes applied before test
commit 0f32502adb9f1dd9fb2eb83460afbec039d819ff Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Dec 23 14:48:40 2020 +0100 tests: Deduplicate boilerplate when POSTing/PUTing an Atom document. commit f1579dc754fb46f16c24f74d8fe5146cdae760df Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Dec 23 13:21:11 2020 +0100 tests: Deduplicate boilerplate when POSTing/PUTing a zip archive. It makes it clearer which are the important arguments for the test. commit 07b0119f30156d3abcca35988999203615eec3c5 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Dec 23 10:42:14 2020 +0100 Fix '# fmt' directives. They were not aligned properly, which causes Black to crash:
$ black --version black, version 20.8b1 $ cat test.py def f(): # fmt: off if True: print() # fmt: on def g(): pass $ black test.py error: cannot format test.py: INTERNAL ERROR: Black produced code that is not equivalent to the source. Please report a bug on https://github.com/psf/black/issues. This diff might be helpful: /tmp/blk_phpp_27o.log Oh no! ๐ฅ ๐ ๐ฅ 1 file failed to reformat. ```
commit edf97f4f613bb1137fb1f15e63a3f199847f6c29
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Dec 22 17:23:34 2020 +0100
Reorganize POST/PUT SWORD tests To group them more logically.
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/499/ for more details.
Comment Actions
Build is green
Patch application report for D4787 (id=17005)
Rebasing onto ae7bfc215f...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-508-D4787.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/508/ for more details.