Differential D4781

Reorganize POST/PUT SWORD tests
ClosedPublic
Actions

Authored by vlorentz on Dec 22 2020, 5:23 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEPbbe591d3f7de: Reorganize POST/PUT SWORD tests

Summary

To group them more logically.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 22 2020, 5:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 22 2020, 5:23 PM

Build has FAILED

Patch application report for D4781 (id=16923)

Rebasing onto b85ca5f976...

Current branch diff-target is up to date.

Changes applied before test

commit 2e6393829cce9de9c9724cd78bcebd58e2717b8b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 22 17:23:34 2020 +0100

    Reorganize POST/PUT SWORD tests
    
    To group them more logically.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/495/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/495/console

Harbormaster failed remote builds in B18070: Diff 16923!Dec 22 2020, 5:24 PM

fix import

Build is green

Patch application report for D4781 (id=16924)

Rebasing onto b85ca5f976...

Current branch diff-target is up to date.

Changes applied before test

commit edf97f4f613bb1137fb1f15e63a3f199847f6c29
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 22 17:23:34 2020 +0100

    Reorganize POST/PUT SWORD tests
    
    To group them more logically.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/496/ for more details.

Harbormaster completed remote builds in B18071: Diff 16924.Dec 22 2020, 5:31 PM

lgtm

(It's long though so i might have skimmed through some parts).

A few remarks on docstrings not updated according to what the module is actually testing.

swh/deposit/tests/api/test_deposit_update.py
5	That sounds like the wrong docstring, here we test updates.
swh/deposit/tests/api/test_deposit_update_binary.py
6	same remark, it's an update...

This revision is now accepted and ready to land.Jan 4 2021, 2:41 PM

fix docstrings

Build is green

Patch application report for D4781 (id=17002)

Rebasing onto b85ca5f976...

Current branch diff-target is up to date.

Changes applied before test

commit bbe591d3f7de496c5b24fb14c8f21737a1d9fc74
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 22 17:23:34 2020 +0100

    Reorganize POST/PUT SWORD tests
    
    To group them more logically.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/505/ for more details.

Harbormaster completed remote builds in B18140: Diff 17002.Jan 4 2021, 3:47 PM

Closed by commit rDDEPbbe591d3f7de: Reorganize POST/PUT SWORD tests (authored by vlorentz). · Explain WhyJan 4 2021, 3:49 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEPbbe591d3f7de: Reorganize POST/PUT SWORD tests.